Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Enable Support for non CUDA Devices. #34

Closed
jonhurlock opened this issue Jul 30, 2024 · 8 comments
Closed

Feature Request: Enable Support for non CUDA Devices. #34

jonhurlock opened this issue Jul 30, 2024 · 8 comments

Comments

@jonhurlock
Copy link

Im currently using M3 Silicon on a MacBook Pro. Currently the code only support CUDA enabled devices. Is there any plan to start to support Metal Performance Shaders (MPS), rather than just CUDA?

@mashb1t
Copy link

mashb1t commented Jul 30, 2024

+1, cross reference see lllyasviel/Fooocus#3406.
Fooocus is using SAM 1.0, support for AMD, MPS and CPU would highly be appreciated!

@emi-dm
Copy link

emi-dm commented Jul 30, 2024

It would be great!! Specially for MacBooks and non GPU laptops

1 similar comment
@jack-gits
Copy link

It would be great!! Specially for MacBooks and non GPU laptops

@vogel2
Copy link

vogel2 commented Aug 1, 2024

We need mps support!

@vivasvan-patel-ev
Copy link

vivasvan-patel-ev commented Aug 1, 2024

Support of Mac chips would be highly appriciated

@sangwf
Copy link

sangwf commented Aug 2, 2024

yes. I need it too.

@daikiad
Copy link

daikiad commented Aug 3, 2024

I have made changes to support Apple's MPS.
#123
Although it's not yet merged, you can check the changes in my forked repository (https://github.com/daikiad/segment-anything-2/tree/add-mps-support). I have tested the SAM2 sample notebook, and it runs mostly successfully. hope this will help

@ronghanghu
Copy link
Contributor

ronghanghu commented Aug 12, 2024

Hi @jonhurlock @mashb1t @emi-dm @vogel2 @vivasvan-patel-ev @sangwf @daikiad , we have added support for CPU and MPS devices in #192, and updated the notebook examples. You can pull the latest code from this repository to try it out. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants