Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix XML context reporting #144

Merged
merged 2 commits into from
Aug 5, 2021
Merged

Fix XML context reporting #144

merged 2 commits into from
Aug 5, 2021

Conversation

facelessuser
Copy link
Owner

@facelessuser facelessuser commented Aug 5, 2021 •
edited
Loading

This affects HTML and other plugins derived from XML

Reference: rojopolis/spellcheck-github-actions#53

@facelessuser
Fix XML context reporting
5da2984 
This affects HTML and other plugins derived from XML
@gir-bot gir-bot added S: needs-review Needs to be reviewed and/or approved. C: docs Related to documentation. C: plugins Related to general plugin code. C: source Related to source code. C: xml-filter Related to the xml filter. labels Aug 5, 2021
@facelessuser
Copy link
Owner Author

Need to add some context tests to verify behavior and prevent breakage in the future.

@gir-bot gir-bot added C: html-filter Related to the html filter. C: tests Related to testing. labels Aug 5, 2021
@facelessuser
Copy link
Owner Author

@gir-bot lgtm

@gir-bot gir-bot added S: approved The pull request is ready to be merged. and removed S: needs-review Needs to be reviewed and/or approved. labels Aug 5, 2021
@facelessuser facelessuser merged commit e64fed9 into master Aug 5, 2021
@facelessuser facelessuser deleted the bugfix/xml-context branch August 5, 2021 15:07
@jonasbn jonasbn mentioned this pull request Aug 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C: docs Related to documentation. C: html-filter Related to the html filter. C: plugins Related to general plugin code. C: source Related to source code. C: tests Related to testing. C: xml-filter Related to the xml filter. S: approved The pull request is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@facelessuser @gir-bot