Skip to content

Conversation

@factset-sdk-bot
Copy link
Collaborator

No description provided.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@saigiridhar21 saigiridhar21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left minor comments.

try {
getAllFiDiscountCurvesResponse = apiInstance.getAllFIDiscountCurvesWithHttpInfo("InvalidCurrency");

Assert.assertTrue("Response should be 400 - Not Found", getAllFiDiscountCurvesResponse.getStatusCode() == 404);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that line 62 will be running. Can you please remove it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed it.

@ksreeramoj ksreeramoj merged commit fbc714a into master Mar 24, 2022
@ksreeramoj ksreeramoj deleted the feat/sdk/analyticsapi-engines-sdk-generator-pr-48 branch March 24, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants