From 4e97200b26ace515b2226c322c40c36fa7573c4f Mon Sep 17 00:00:00 2001
From: Matt Mayer <matt@lemi.travel>
Date: Tue, 21 Mar 2023 02:21:08 +0700
Subject: [PATCH] fix(locale): split zh_TW first_names by gender (#1941)

---
 src/locales/zh_TW/person/female_first_name.ts |  43 ++++++
 src/locales/zh_TW/person/first_name.ts        | 123 ++----------------
 src/locales/zh_TW/person/index.ts             |   4 +
 src/locales/zh_TW/person/male_first_name.ts   |  74 +++++++++++
 4 files changed, 129 insertions(+), 115 deletions(-)
 create mode 100644 src/locales/zh_TW/person/female_first_name.ts
 create mode 100644 src/locales/zh_TW/person/male_first_name.ts

diff --git a/src/locales/zh_TW/person/female_first_name.ts b/src/locales/zh_TW/person/female_first_name.ts
new file mode 100644
index 00000000000..f81b54c726d
--- /dev/null
+++ b/src/locales/zh_TW/person/female_first_name.ts
@@ -0,0 +1,43 @@
+export default [
+  '俊馳',
+  '凱瑞',
+  '博濤',
+  '嘉懿',
+  '子涵',
+  '子騫',
+  '子默',
+  '思淼',
+  '懿軒',
+  '擎蒼',
+  '旭堯',
+  '昊焱',
+  '晟睿',
+  '智宸',
+  '智淵',
+  '曉博',
+  '曉嘯',
+  '楷瑞',
+  '樂駒',
+  '瀟然',
+  '炫明',
+  '煜城',
+  '煜祺',
+  '熠彤',
+  '燁磊',
+  '燁華',
+  '燁霖',
+  '瑾瑜',
+  '睿淵',
+  '立軒',
+  '笑愚',
+  '聰健',
+  '苑博',
+  '越彬',
+  '鈺軒',
+  '錦程',
+  '靖琪',
+  '風華',
+  '鶴軒',
+  '鷺洋',
+  '黎昕',
+];
diff --git a/src/locales/zh_TW/person/first_name.ts b/src/locales/zh_TW/person/first_name.ts
index 5bd1e4c9920..40a647ec054 100644
--- a/src/locales/zh_TW/person/first_name.ts
+++ b/src/locales/zh_TW/person/first_name.ts
@@ -1,115 +1,8 @@
-export default [
-  '俊馳',
-  '修傑',
-  '修潔',
-  '偉宸',
-  '偉澤',
-  '偉祺',
-  '偉誠',
-  '健柏',
-  '健雄',
-  '凱瑞',
-  '博文',
-  '博濤',
-  '博超',
-  '君浩',
-  '哲瀚',
-  '嘉懿',
-  '嘉熙',
-  '天宇',
-  '天磊',
-  '天翊',
-  '子涵',
-  '子軒',
-  '子騫',
-  '子默',
-  '展鵬',
-  '峻熙',
-  '建輝',
-  '弘文',
-  '志強',
-  '志澤',
-  '思淼',
-  '思源',
-  '思聰',
-  '思遠',
-  '懿軒',
-  '振家',
-  '擎宇',
-  '擎蒼',
-  '文博',
-  '文昊',
-  '文軒',
-  '旭堯',
-  '昊天',
-  '昊強',
-  '昊焱',
-  '昊然',
-  '明哲',
-  '明杰',
-  '明軒',
-  '明輝',
-  '晉鵬',
-  '晟睿',
-  '智宸',
-  '智淵',
-  '智輝',
-  '曉博',
-  '曉嘯',
-  '梓晨',
-  '楷瑞',
-  '榮軒',
-  '樂駒',
-  '正豪',
-  '浩宇',
-  '浩然',
-  '浩軒',
-  '澤洋',
-  '瀟然',
-  '炎彬',
-  '炫明',
-  '煜城',
-  '煜祺',
-  '熠彤',
-  '燁偉',
-  '燁磊',
-  '燁華',
-  '燁霖',
-  '瑞霖',
-  '瑾瑜',
-  '皓軒',
-  '睿淵',
-  '立果',
-  '立誠',
-  '立軒',
-  '立輝',
-  '笑愚',
-  '紹輝',
-  '紹齊',
-  '耀傑',
-  '聰健',
-  '胤祥',
-  '致遠',
-  '苑博',
-  '語堂',
-  '越彬',
-  '越澤',
-  '遠航',
-  '金鑫',
-  '鈺軒',
-  '錦程',
-  '鑫磊',
-  '鑫鵬',
-  '雨澤',
-  '雪松',
-  '靖琪',
-  '風華',
-  '鴻濤',
-  '鴻煊',
-  '鵬濤',
-  '鵬煊',
-  '鵬飛',
-  '鶴軒',
-  '鷺洋',
-  '黎昕',
-];
+// We don't have a generic first name list for this locale
+// So simply concatenate male and female lists and remove any duplicates
+// This avoids falling back to fallback locale
+import { mergeArrays } from './../../../internal/merge';
+import female_first_name from './female_first_name';
+import male_first_name from './male_first_name';
+
+export default mergeArrays(female_first_name, male_first_name);
diff --git a/src/locales/zh_TW/person/index.ts b/src/locales/zh_TW/person/index.ts
index 7b03f9f1347..aa067bc01ab 100644
--- a/src/locales/zh_TW/person/index.ts
+++ b/src/locales/zh_TW/person/index.ts
@@ -3,17 +3,21 @@
  * Run 'pnpm run generate:locales' to update.
  */
 import type { PersonDefinitions } from '../../..';
+import female_first_name from './female_first_name';
 import female_prefix from './female_prefix';
 import first_name from './first_name';
 import last_name from './last_name';
+import male_first_name from './male_first_name';
 import male_prefix from './male_prefix';
 import name_ from './name';
 import prefix from './prefix';
 
 const person: PersonDefinitions = {
+  female_first_name,
   female_prefix,
   first_name,
   last_name,
+  male_first_name,
   male_prefix,
   name: name_,
   prefix,
diff --git a/src/locales/zh_TW/person/male_first_name.ts b/src/locales/zh_TW/person/male_first_name.ts
new file mode 100644
index 00000000000..9ae32c1416d
--- /dev/null
+++ b/src/locales/zh_TW/person/male_first_name.ts
@@ -0,0 +1,74 @@
+export default [
+  '修傑',
+  '修潔',
+  '偉宸',
+  '偉澤',
+  '偉祺',
+  '偉誠',
+  '健柏',
+  '健雄',
+  '博文',
+  '博超',
+  '君浩',
+  '哲瀚',
+  '嘉熙',
+  '天宇',
+  '天磊',
+  '天翊',
+  '子軒',
+  '展鵬',
+  '峻熙',
+  '建輝',
+  '弘文',
+  '志強',
+  '志澤',
+  '思源',
+  '思聰',
+  '思遠',
+  '振家',
+  '擎宇',
+  '文博',
+  '文昊',
+  '文軒',
+  '昊天',
+  '昊強',
+  '昊然',
+  '明哲',
+  '明杰',
+  '明軒',
+  '明輝',
+  '晉鵬',
+  '智輝',
+  '梓晨',
+  '榮軒',
+  '正豪',
+  '浩宇',
+  '浩然',
+  '浩軒',
+  '澤洋',
+  '炎彬',
+  '燁偉',
+  '瑞霖',
+  '皓軒',
+  '立果',
+  '立誠',
+  '立輝',
+  '紹輝',
+  '紹齊',
+  '耀傑',
+  '胤祥',
+  '致遠',
+  '語堂',
+  '越澤',
+  '遠航',
+  '金鑫',
+  '鑫磊',
+  '鑫鵬',
+  '雨澤',
+  '雪松',
+  '鴻濤',
+  '鴻煊',
+  '鵬濤',
+  '鵬煊',
+  '鵬飛',
+];