From 3946df788fdf1e69848e9b6044fced29f52316f2 Mon Sep 17 00:00:00 2001 From: Shinigami Date: Tue, 22 Mar 2022 20:38:53 +0100 Subject: [PATCH 1/4] ci: configure codecov patch threshold (#647) --- .github/.codecov.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/.codecov.yml b/.github/.codecov.yml index d782656df33..21bd0ca39a9 100644 --- a/.github/.codecov.yml +++ b/.github/.codecov.yml @@ -11,3 +11,7 @@ coverage: default: target: 95% threshold: 2% + patch: + default: + target: 95% + threshold: 1% From 7f32614702f569d70a8a7744bd3aeb31279599fd Mon Sep 17 00:00:00 2001 From: ST-DDT Date: Wed, 23 Mar 2022 08:11:00 +0100 Subject: [PATCH 2/4] docs: fix page meta (#659) --- docs/.vitepress/config.mjs | 23 +++++++++++++++++++---- 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/docs/.vitepress/config.mjs b/docs/.vitepress/config.mjs index 60799a0eb4f..83f5b0fb700 100644 --- a/docs/.vitepress/config.mjs +++ b/docs/.vitepress/config.mjs @@ -62,27 +62,42 @@ export default defineConfig({ [ 'meta', { - property: 'og:description', + name: 'og:description', content: description, }, + ], + [ + 'meta', { name: 'twitter:description', content: description, }, + ], + [ + 'meta', { name: 'description', content: description, }, + ], + [ + 'meta', { - property: 'og:image', + name: 'og:image', content: image, }, + ], + [ + 'meta', { - property: 'twitter:image', + name: 'twitter:image', content: image, }, + ], + [ + 'meta', { - property: 'twitter:card', + name: 'twitter:card', content: 'summary_large_image', }, ], From a759c8707c2e3758e64e1c174c2de7aad51cd64b Mon Sep 17 00:00:00 2001 From: Daniel Bannert Date: Wed, 23 Mar 2022 09:06:00 +0100 Subject: [PATCH 3/4] fix: enable algolia search (#641) --- docs/.vitepress/config.mjs | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/docs/.vitepress/config.mjs b/docs/.vitepress/config.mjs index 83f5b0fb700..8c15b49db9f 100644 --- a/docs/.vitepress/config.mjs +++ b/docs/.vitepress/config.mjs @@ -40,13 +40,10 @@ const sidebar = { ], }; -// grab from process.env once this is building on netlify const algolia = { - apiKey: '', - indexName: '', - searchParameters: { - facetFilters: [''], - }, + apiKey: process.env.API_KEY, + appId: process.env.APP_ID, + indexName: 'fakerjs', }; const description = @@ -111,7 +108,6 @@ export default defineConfig({ editLinkText: 'Suggest changes to this page', nav, sidebar, - // TODO 2022-03-06: https://github.com/faker-js/faker/issues/222 - // algolia, + algolia, }, }); From 3f3de78c83ae919fd44531ac7ae9caed885800d4 Mon Sep 17 00:00:00 2001 From: Jelle Hulter Date: Wed, 23 Mar 2022 09:29:48 +0100 Subject: [PATCH 4/4] fix: corrected the Costa Rican IBAN format (#646) --- src/iban.ts | 8 +++++-- test/finance_iban.spec.ts | 44 +++++++++++++++++++++++++++++++++++++++ 2 files changed, 50 insertions(+), 2 deletions(-) diff --git a/src/iban.ts b/src/iban.ts index 3f10e91be2e..b608357ee93 100644 --- a/src/iban.ts +++ b/src/iban.ts @@ -206,8 +206,12 @@ export = { }, { country: 'CR', - total: 21, + total: 22, bban: [ + { + type: 'n', + count: 1, + }, { type: 'n', count: 3, @@ -217,7 +221,7 @@ export = { count: 14, }, ], - format: 'CRkk bbbc cccc cccc cccc c', + format: 'CRkk xbbb cccc cccc cccc cc', }, { country: 'HR', diff --git a/test/finance_iban.spec.ts b/test/finance_iban.spec.ts index 23768387d85..5c3fb9c9b6b 100644 --- a/test/finance_iban.spec.ts +++ b/test/finance_iban.spec.ts @@ -255,6 +255,50 @@ describe('finance_iban', () => { 'the result should be equal to 1' ).toBe(1); }); + + it('IBAN for Costa Rica is correct', () => { + // Costa Rica + // https://wise.com/us/iban/costa-rica + // Length 22 + // BBAN 1n,3n,14n + // CRkk xbbb cccc cccc cccc cccc cccc + // x = reserve digit + // b = National bank code (digits) + // c = Account number (digits) + + // example IBAN CR05 0152 0200 1026 2840 66 + + const iban = faker.finance.iban(false, 'CR'); + + expect(iban).satisfy(validator.isIBAN); + + const ibanFormated = iban.match(/.{1,4}/g).join(' '); + const bban = iban.substring(4) + iban.substring(0, 4); + + expect( + 22, + `CR IBAN would be 22 chars length, given is ${iban.length}` + ).toBe(iban.length); + + expect( + iban.substring(0, 2), + iban.substring(0, 2) + + "must start with 'CR' in CR IBAN " + + ibanFormated + ).to.eq('CR'); + + expect( + iban.substring(2, 22), + iban.substring(2, 22) + + ' must contains only digit in AZ IBAN ' + + ibanFormated + ).match(/^\d{20}$/); + + expect( + ibanLib.mod97(ibanLib.toDigitString(bban)), + 'the result should be equal to 1' + ).toBe(1); + }); }); } });