From 0c3cda65a3f5a2f3aeb24149e18c8fd413347b87 Mon Sep 17 00:00:00 2001 From: Phil Duffen Date: Mon, 29 Jan 2018 12:14:12 +0000 Subject: [PATCH 1/2] Modify Modify Faker::Internet.slug Before: slug('Something Co., Ltd.','-') => "something-co.,-ltd." After: slug('Something Co., Ltd.','-') => "something-co-ltd" --- lib/faker/internet.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/faker/internet.rb b/lib/faker/internet.rb index 6668a65c61..21fdb99ffb 100644 --- a/lib/faker/internet.rb +++ b/lib/faker/internet.rb @@ -161,7 +161,7 @@ def url(host = domain_name, path = "/#{user_name}", scheme = 'http') def slug(words = nil, glue = nil) glue ||= sample(%w[- _ .]) - (words || Faker::Lorem::words(2).join(' ')).gsub(' ', glue).downcase + (words || Faker::Lorem::words(2).join(' ')).delete(',.').gsub(' ', glue).downcase end def device_token From 40add9b1446505a12fd098f74cbd145720ac58eb Mon Sep 17 00:00:00 2001 From: Phil Duffen Date: Mon, 14 May 2018 18:40:44 +0100 Subject: [PATCH 2/2] Add test for unwanted slug content i.e. extraneous commas and full stops. --- test/test_faker_internet.rb | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/test/test_faker_internet.rb b/test/test_faker_internet.rb index 651e1bd935..e670cb2ecd 100644 --- a/test/test_faker_internet.rb +++ b/test/test_faker_internet.rb @@ -212,6 +212,10 @@ def test_slug_with_content_arg assert @tester.slug('Foo bAr baZ').match(/^foo(_|\.|\-)bar(_|\.|\-)baz$/) end + def test_slug_with_unwanted_content_arg + assert @tester.slug('Foo.. bAr., baZ,,').match(/^foo(_|\.|\-)bar(_|\.|\-)baz$/) + end + def test_slug_with_glue_arg assert @tester.slug(nil, '+').match(/^[a-z]+\+[a-z]+$/) end