From 3f103fd0efe9fed03d06fb669bb3cec798ed3617 Mon Sep 17 00:00:00 2001 From: Vitor Oliveira Date: Sat, 19 May 2018 17:33:17 -0300 Subject: [PATCH 1/2] Fix mini test warnings --- test/test_faker_music.rb | 4 ++-- test/test_helper.rb | 6 ++---- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/test/test_faker_music.rb b/test/test_faker_music.rb index dbe73ebfac..df1706d320 100644 --- a/test/test_faker_music.rb +++ b/test/test_faker_music.rb @@ -34,7 +34,7 @@ def test_chord_types end def test_key - assert @tester.name.match(/([A-Z])+(b|#){0,1}+(m){0,1}/) + assert @tester.name.match(/([A-Z])\s*(b|#){0,1}\s*(m){0,1}/) end def test_instrument @@ -42,7 +42,7 @@ def test_instrument end def test_chord - assert @tester.name.match(/([A-Z])+(b|#){0,1}+([a-zA-Z0-9]{0,4})/) + assert @tester.name.match(/([A-Z])\s*(b|#){0,1}\s*([a-zA-Z0-9]{0,4})/) end def test_band diff --git a/test/test_helper.rb b/test/test_helper.rb index 46f23f76a8..266eeda0f2 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -3,10 +3,8 @@ require 'simplecov' require 'coveralls' - SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[ - SimpleCov::Formatter::HTMLFormatter, - Coveralls::SimpleCov::Formatter - ] + simplecov_params = [SimpleCov::Formatter::HTMLFormatter, Coveralls::SimpleCov::Formatter] + SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter.new(simplecov_params) SimpleCov.start do add_filter ['.bundle', 'lib/helpers', 'lib/extensions', 'test'] end From 7fb87e0de91538f28cd39e5e286a3f7f7aef9b29 Mon Sep 17 00:00:00 2001 From: Vitor Oliveira Date: Sat, 19 May 2018 18:10:09 -0300 Subject: [PATCH 2/2] Update Changelog.md --- CHANGELOG.md | 7 +++++++ tasks/test.rake | 1 - 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9aab46e8e5..74c8d200b9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,13 @@ **Additions** +- [PR #1223](https://github.com/stympy/faker/pull/1223) Fix minitest warnings [@vbrazo](https://github.com/vbrazo) +- [PR #1174](https://github.com/stympy/faker/pull/1174) Dota2 API: Str Heroes, heroes quotes, Items, Teams, Players [@felipesousafs](https://github.com/darylf) +- [PR #974](https://github.com/stympy/faker/pull/974) Specify version number each class was introduced [@darylf](https://github.com/darylf) +- [PR #1221](https://github.com/stympy/faker/pull/1221) Updated the Readme file with the new logo [@tobaloidee](https://github.com/tobaloidee) +- [PR #439](https://github.com/stympy/faker/pull/439) Remove Eichmann surname [@jonahwh](https://github.com/jonahwh) +- [PR #1220](https://github.com/stympy/faker/pull/1220) Updates for Faker::Myst [@SpyMaster356](https://github.com/SpyMaster356) +- [PR #1128](https://github.com/stympy/faker/pull/1128) Use ruby syntax highlighting in Omniauth doc [@swrobel](https://github.com/swrobel) - [PR #1204](https://github.com/stympy/faker/pull/1204) Update sample output of `Faker::App.version` [@joshuapinter](https://github.com/joshuapinter) - [PR #1218](https://github.com/stympy/faker/pull/1218) Add Faker::Myst [@SpyMaster356](https://github.com/SpyMaster356) - [PR #1192](https://github.com/stympy/faker/pull/1192) Space: Added space launch vehicule [@gauth-ier](https://github.com/Gauth-ier) diff --git a/tasks/test.rake b/tasks/test.rake index eda89c3211..150fe47be0 100644 --- a/tasks/test.rake +++ b/tasks/test.rake @@ -4,7 +4,6 @@ Rake::TestTask.new do |t| t.libs << 'test' t.libs << '.' t.test_files = FileList['test/test*.rb'] - t.verbose = true t.warning = true end