Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move event-generator #1089

Closed
leodido opened this issue Mar 12, 2020 · 6 comments · Fixed by #1156
Closed

Move event-generator #1089

leodido opened this issue Mar 12, 2020 · 6 comments · Fixed by #1156
Assignees

Comments

@leodido
Copy link
Member

leodido commented Mar 12, 2020

Motivation

The event-generator tool is a C++ tool written by @mstemm to generate events Falco can catch.

In the past (example: the PSP generator), we decided to let stay in Falco only what really is Falco.
Which means, that side tooling should live somewhere else.

Furthermore does not seems perfectly fine to me that its source code is inside the docker directory.

Feature

Discuss in the public (and then act) whether the event-generator tool has to live in Falco or somewhere else.

I see some options:

  1. move it to its own C++ repo
  2. rewrite it in Go as a library (pkg) and integrate into falcoctl
  3. use it from falcoctl using the docker image exposing the binary build in case (1)

Alternatives

Keep it here.

Additional context

I'll propose a discussion about this in the next community call.

Just talked with @leogr that is available to port it in Go if we all decide like so.

@leogr
Copy link
Member

leogr commented Mar 19, 2020

I would prefer option 2. In that case, I could help!

@leogr
Copy link
Member

leogr commented Apr 2, 2020

/assign

@leogr
Copy link
Member

leogr commented Apr 8, 2020

@leogr
Copy link
Member

leogr commented Apr 8, 2020

As discussed during the community call, we decide to move the new event-generator to the Falco org and - when ready - use it as a replacement for the old one.

The new one will live in its own repo.

I suggest keeping this issue open until the old one can be removed from this repo.

@leodido
Copy link
Member Author

leodido commented Apr 8, 2020 via email

@leogr
Copy link
Member

leogr commented Apr 21, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants