Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why are the default rules marked as deprecated? #1392

Closed
chmreid opened this issue Sep 10, 2020 · 2 comments
Closed

Why are the default rules marked as deprecated? #1392

chmreid opened this issue Sep 10, 2020 · 2 comments

Comments

@chmreid
Copy link

chmreid commented Sep 10, 2020

What to document

In the default falco rules file here, around line 550 a comment says "These macros will be removed soon. Only keeping them to maintain compatiblity with some widely used rules files." I am confused about why these are being removed, since there are many useful rules in that file. Is the plan to move those rules to a different file that will still be available but not enabled by default? The rules documentation page does not mention anything about deprecation of the default rule set so it would be helpful to add some clarification to that page. Appreciate the help!

@chmreid
Copy link
Author

chmreid commented Sep 10, 2020

Doing a git blame shows that that comment was added back in 2018 by @mstemm (#326) during a significant rewrite of the rules file.

@chmreid
Copy link
Author

chmreid commented Sep 10, 2020

Oh, I see - I missed a comment about 100 lines later that says end of deprecated section, so the deprecated comment applies to a few rules, not all the rules: https://github.com/falcosecurity/falco/blob/master/rules/falco_rules.yaml#L635

@chmreid chmreid closed this as completed Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant