Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tag typos #1143

Merged
merged 2 commits into from
Apr 14, 2020
Merged

Fix tag typos #1143

merged 2 commits into from
Apr 14, 2020

Conversation

sporkmonger
Copy link
Contributor

@sporkmonger sporkmonger commented Apr 14, 2020

What type of PR is this?

/kind bug

/kind rule-update

Any specific area of the project related to this PR?

/area rules

What this PR does / why we need it:

Some rules currently use "mitre_defense_evation" tag instead of the correct tag of "mitre_defense_evasion". Other rules use the correct tag. Anything matching against these tags would currently need to check for both.

Which issue(s) this PR fixes:

Fixes #1142

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

rule(Delete or rename shell history): "mitre_defense_evation" tag corrected to "mitre_defense_evasion"
rule(Delete Bash History): "mitre_defense_evation" tag corrected to "mitre_defense_evasion"

Bob Aman added 2 commits April 13, 2020 19:41
Signed-off-by: Bob Aman <bob@sporkmonger.com>
Signed-off-by: Bob Aman <bob@sporkmonger.com>
@poiana
Copy link
Contributor

poiana commented Apr 14, 2020

Welcome @sporkmonger! It looks like this is your first PR to falcosecurity/falco 🎉

@poiana poiana added the size/XS label Apr 14, 2020
@sporkmonger sporkmonger changed the title Fix/tag typos Fix tag typos Apr 14, 2020
@poiana
Copy link
Contributor

poiana commented Apr 14, 2020

LGTM label has been added.

Git tree hash: 8a41a4be852c497b402134318d7cb5369b70305f

@poiana
Copy link
Contributor

poiana commented Apr 14, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fntlnz
Copy link
Contributor

fntlnz commented Apr 14, 2020

Thanks a lot @sporkmonger

@leodido leodido removed the request for review from mfdii April 14, 2020 10:35
@leodido leodido added this to the 0.22.0 milestone Apr 14, 2020
@poiana poiana merged commit ffa137f into falcosecurity:master Apr 14, 2020
@sporkmonger sporkmonger deleted the fix/tag-typos branch April 14, 2020 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in rule tags: mitre_defense_evasion vs mitre_defense_evation
4 participants