Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct "drivers build gruid" URLs #1160

Merged
merged 1 commit into from
Apr 24, 2020
Merged

Conversation

leodido
Copy link
Member

@leodido leodido commented Apr 24, 2020

Co-authored-by: Lorenzo Fontana lo@linux.com
Signed-off-by: Leonardo Di Donato leodidonato@gmail.com

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

NONE

What this PR does / why we need it:

It fixes the URL from which the falco-driver-loader script fetches the drivers.

In fact, the correct URL does not contain the distinction between the driver type (eBPF probe or kernel module): the structure is flat on the server.

Eg.,

https://dl.bintray.com/driver/$driver_version$/falco_$target$_$kernelrelease$_$kernelversion$.[ko|o]

Which issue(s) this PR fixes:

Fixes #1125

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

BREAKING CHANGE: the `falco-driver-loader` script environment variable to use a custom repository to download drivers now uses the `DRIVERS_REPO` environment variable instead of `DRIVER_LOOKUP_URL`. This variable must contain the parent URI containing the following directory structure `/$driver_version$/falco_$target$_$kernelrelease$_$kernelversion$.[ko|o]`. e.g: `
https://dl.bintray.com/driver/$driver_version$/falco_$target$_$kernelrelease$_$kernelversion$.[ko|o]`

Co-authored-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@leodido
Copy link
Member Author

leodido commented Apr 24, 2020

/cc @fntlnz

@poiana poiana requested a review from fntlnz April 24, 2020 11:23
@poiana poiana added the lgtm label Apr 24, 2020
@poiana
Copy link
Contributor

poiana commented Apr 24, 2020

LGTM label has been added.

Git tree hash: 06a5746dad6369b1d08c435a3f280574fca09996

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@poiana
Copy link
Contributor

poiana commented Apr 24, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

falco-driver-loader improvements proposal
4 participants