Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(test): instructions to run regression test suites locally #1234

Merged
merged 2 commits into from
May 26, 2020
Merged

docs(test): instructions to run regression test suites locally #1234

merged 2 commits into from
May 26, 2020

Conversation

leodido
Copy link
Member

@leodido leodido commented May 25, 2020

What type of PR is this?

/kind documentation

Any specific area of the project related to this PR?

/area tests

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

docs(test): instructions to run regression test suites locally

leodido and others added 2 commits May 25, 2020 09:01
@leodido @fntlnz
build(test): requirements.txt
9149821 
Co-authored-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@leodido @fntlnz
docs(test): run locally handling python deps with venv
cd33551 
Co-authored-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@leodido leodido changed the title Update/tests venv docs(test): instructions to run regression test suites locally May 25, 2020
@poiana poiana requested review from Kaizhe and leogr May 25, 2020 09:18
@poiana poiana added the size/M label May 25, 2020
@leodido
Copy link
Member Author

leodido commented May 25, 2020

/milestone 0.23.0

@poiana
Copy link
Contributor

poiana commented May 25, 2020

@leodido: The provided milestone is not valid for this repository. Milestones in this repository: [0.24.0, 1.0.0]

Use /milestone clear to clear the milestone.

In response to this:

/milestone 0.23.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana added the lgtm label May 25, 2020
@poiana
Copy link
Contributor

poiana commented May 25, 2020

LGTM label has been added.

Git tree hash: 431ef59ad71ce576900251ce80e786e5260a9e28

@leogr
Copy link
Member

leogr commented May 25, 2020

/milestone 0.24.0

@poiana poiana added this to the 0.24.0 milestone May 25, 2020
leogr
leogr approved these changes May 26, 2020
View reviewed changes
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@poiana poiana merged commit 3bfd94f into master May 26, 2020
@poiana poiana deleted the update/tests-venv branch May 26, 2020 13:02
@poiana
Copy link
Contributor

poiana commented May 26, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leogr leogr leogr approved these changes

@fntlnz fntlnz fntlnz approved these changes

@Kaizhe Kaizhe Awaiting requested review from Kaizhe

Assignees

@fntlnz fntlnz

@leogr leogr

Labels
approved dco-signoff: yes kind/documentation lgtm release-note size/M
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@leodido @poiana @leogr @fntlnz