Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rule(macro root_dir): correct macro to exactly match the /root dir and not other with just /root as a prefix #1279

Merged
merged 2 commits into from
Jun 26, 2020

Conversation

leogr
Copy link
Member

@leogr leogr commented Jun 24, 2020

What type of PR is this?

/kind bug
/kind rule-update

Any specific area of the project related to this PR?

/area rules

What this PR does / why we need it:

👉 #1141

Which issue(s) this PR fixes:

Fixes #1141

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

rule(macro root_dir): correct macro to exactly match the `/root` dir and not other with just `/root` as a prefix  

Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@leogr
Copy link
Member Author

leogr commented Jun 24, 2020

/milestone 0.24.0

@fntlnz
Copy link
Contributor

fntlnz commented Jun 25, 2020

/cc @Kaizhe

@poiana poiana requested a review from Kaizhe June 25, 2020 12:55
fntlnz
fntlnz previously approved these changes Jun 25, 2020
leodido
leodido previously approved these changes Jun 25, 2020
rules/falco_rules.yaml Outdated Show resolved Hide resolved
@poiana poiana removed the lgtm label Jun 25, 2020
@leodido
Copy link
Member

leodido commented Jun 25, 2020

/hold

Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@leogr leogr requested review from Kaizhe, leodido and fntlnz June 26, 2020 11:40
@leogr
Copy link
Member Author

leogr commented Jun 26, 2020

Change requested applied by 5f0d1b8

Please review again

/hold cancel

Thanks!

Copy link
Contributor

@Kaizhe Kaizhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@poiana poiana added the lgtm label Jun 26, 2020
@poiana
Copy link
Contributor

poiana commented Jun 26, 2020

LGTM label has been added.

Git tree hash: 35335c202f492ebad59b38f842556ffe256ed5c4

@poiana
Copy link
Contributor

poiana commented Jun 26, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kaizhe, leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 27037e6 into master Jun 26, 2020
@poiana poiana deleted the fix/rootdir-macro branch June 26, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The root_dir macro matches /root123abc
5 participants