-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rule(macro root_dir
): correct macro to exactly match the /root
dir and not other with just /root
as a prefix
#1279
Conversation
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
/milestone 0.24.0 |
/cc @Kaizhe |
/hold |
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Change requested applied by 5f0d1b8 Please review again /hold cancel Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 35335c202f492ebad59b38f842556ffe256ed5c4
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Kaizhe, leodido The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/kind rule-update
Any specific area of the project related to this PR?
/area rules
What this PR does / why we need it:
👉 #1141
Which issue(s) this PR fixes:
Fixes #1141
Special notes for your reviewer:
Does this PR introduce a user-facing change?: