Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rules: Adding user.loginuid to the default falco rules #1369

Merged

Conversation

csschwe
Copy link
Contributor

@csschwe csschwe commented Aug 26, 2020

This update will provide information as to which process uid initiated the event. This is really important for processes that are started by a different user name.

What type of PR is this?

/kind feature
/kind rule-update

Any specific area of the project related to this PR?

/area rules

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #318

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
yes

rule: adds user.loginuid to the default Falco rules that also contain user.name

@poiana
Copy link
Contributor

poiana commented Aug 26, 2020

Welcome @csschwe! It looks like this is your first PR to falcosecurity/falco 🎉

@poiana poiana added the size/L label Aug 26, 2020
…e exists

This update will provide information as to which process uid intitiated the event.  This is really important for processes that are started
by a different user name.

Signed-off-by: Chuck Schweizer <chuck.schweizer.lvk2@statefarm.com>
@csschwe csschwe force-pushed the set-user-loginuid-default-rules branch from d18ba65 to 8aed40b Compare August 26, 2020 19:13
@leogr
Copy link
Member

leogr commented Aug 27, 2020

Thank you!

I will try this ASAP

/milestone 0.26.0
/cc @Kaizhe

@poiana poiana requested a review from Kaizhe August 27, 2020 12:29
@poiana poiana added this to the 0.26.0 milestone Aug 27, 2020
@Kaizhe
Copy link
Contributor

Kaizhe commented Aug 27, 2020

/lgtm

@poiana
Copy link
Contributor

poiana commented Aug 27, 2020

LGTM label has been added.

Git tree hash: 36d4adfdab60b83afe5b234b4310ac9f8178f7cd

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@poiana
Copy link
Contributor

poiana commented Aug 28, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kaizhe, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit d678be5 into falcosecurity:master Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants