Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposals: Artifacts Storage + Artifacts Cleanup #1375

Merged
merged 5 commits into from
Sep 7, 2020

Conversation

leodido
Copy link
Member

@leodido leodido commented Sep 1, 2020

What type of PR is this?

/kind design

/kind documentation

Any specific area of the project related to this PR?

/area proposals

What this PR does / why we need it:

This PR introduces two proposals:

  1. Artifacts Storage

    A document representing the State of Art of the Falco Artifacts Storage: when they get created, how they get created, where they get published

  2. Artifacts Cleanup

    A document proposing the cleanup strategy to implement on top of the existing artifacts storage process

Which issue(s) this PR fixes:

NONE

Special notes for your reviewer:

WIP

Does this PR introduce a user-facing change?:

docs(proposals): artifacts storage
docs(proposals): artifacts cleanup

Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@leodido leodido marked this pull request as ready for review September 1, 2020 23:15
@leodido
Copy link
Member Author

leodido commented Sep 1, 2020

/cc @fntlnz @kris-nova

@poiana poiana requested review from fntlnz and krisnova September 1, 2020 23:15
@leodido leodido changed the title proposal: Artifacts Storage proposals: Artifacts Storage + Artifacts Cleanup Sep 2, 2020
@leodido
Copy link
Member Author

leodido commented Sep 2, 2020

Implementation of the drivers cleanup part here -> falcosecurity/test-infra#169

@leodido
Copy link
Member Author

leodido commented Sep 2, 2020

/milestone 0.26.0

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great proposal! 👏

Just left few comments, but it already seems good to me.

Thank you

proposals/20200818-artifacts-storage.md Show resolved Hide resolved
proposals/20200818-artifacts-storage.md Outdated Show resolved Hide resolved
proposals/20200901-artifacts-cleanup.md Show resolved Hide resolved
fntlnz
fntlnz previously approved these changes Sep 3, 2020
@poiana
Copy link
Contributor

poiana commented Sep 3, 2020

LGTM label has been added.

Git tree hash: 15a75e579f56f9977a8f9d1124dff2f5257b7e0e

@poiana poiana added the approved label Sep 3, 2020
…rt basis


Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Co-authored-by: Leonardo Grasso <me@leonardograsso.com>
@poiana poiana added the lgtm label Sep 7, 2020
@poiana
Copy link
Contributor

poiana commented Sep 7, 2020

LGTM label has been added.

Git tree hash: 7ca5b6fd2102d2d100c9344ea7132dbeaa96372a

@poiana poiana added the approved label Sep 7, 2020
@poiana
Copy link
Contributor

poiana commented Sep 7, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit d25e073 into master Sep 7, 2020
@poiana poiana deleted the proposal/artifacts-storage branch September 7, 2020 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants