package manager launched makro - rhsm cert updates, apt #1385

epcim · 2020-09-08T14:58:17Z

Note: the parsed logs on ES shows that rhsmcertd-worke is not pname or aname[*] but can be matched by proc.pname= rhsmcertd.

What type of PR is this?
/kind rule-update

Any specific area of the project related to this PR?

/area rules

rule(list rpm_binaries): add rhsmcertd
rule(list deb_binaries): add apt.systemd.daily

epcim · 2020-09-08T15:05:39Z

leodido · 2020-09-08T16:46:27Z

Hello @epcim, thanks for looking into this!

Would you please sign-off your commit as per contributing guidelines and use the PR template (in particular, the release-note block is missing)? Thanks 😃

leogr · 2020-10-13T13:27:05Z

/cc @Kaizhe

epcim · 2020-10-19T15:16:59Z

@leodido it is already signed.. see

@poiana poiana added dco-signoff: yes and removed dco-signoff: no labels on 8 Sep

epcim · 2020-10-26T19:08:18Z

anything else needed here?

leogr · 2020-10-27T10:42:25Z

anything else needed here?

The release-note block is missing. You can grab it from the PR template here 👉 https://github.com/falcosecurity/falco/blob/master/.github/PULL_REQUEST_TEMPLATE.md

epcim · 2020-11-02T08:24:26Z

I am not sure what else is needed than what I just updated in the comment. If you need anything specific, update send an update against my MR.. etc..

nibalizer · 2020-12-12T19:57:32Z

Hi @epcim thanks for this and sorry for the delay.

We generate our changelogs from the PR message and the bot looks for specific blocks in the message. Can you edit your top message to wrap the user notes in a block:

```release-note
list(rpm_binaries): add rhsmcertd
list(debian_binaries): apt.systemd.dai


Thanks and let me know if you need more direction.

nibalizer · 2020-12-12T19:59:57Z

rules/falco_rules.yaml

@@ -227,7 +227,7 @@
 - list: deb_binaries
  items: [dpkg, dpkg-preconfigu, dpkg-reconfigur, dpkg-divert, apt, apt-get, aptitude,
    frontend, preinst, add-apt-reposit, apt-auto-remova, apt-key,
-    apt-listchanges, unattended-upgr, apt-add-reposit, apt-config, apt-cache
+    apt-listchanges, unattended-upgr, apt-add-reposit, apt-config, apt-cache, apt.systemd.dai


Is this supposed to be apt.systemd.daily?

Yup, but all the items' lengths are capped to 15 characters...

epcim · 2020-12-13T10:16:28Z

I think so Spencer Krum <notifications@github.com> wrote: @nibalizer commented on this pull request. In rules/falco_rules.yaml:

@@ -227,7 +227,7 @@

- list: deb_binaries items: [dpkg, dpkg-preconfigu, dpkg-reconfigur, dpkg-divert, apt, apt-get, aptitude, frontend, preinst, add-apt-reposit, apt-auto-remova, apt-key, - apt-listchanges, unattended-upgr, apt-add-reposit, apt-config, apt-cache + apt-listchanges, unattended-upgr, apt-add-reposit, apt-config, apt-cache, apt.systemd.dai Is this supposed to be apt.systemd.daily? —You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.

leodido

LGTM

But please, next time, use the provided PR template.

It will help us review your PR better and sooner.

This time, I've edited the PR corpus myself to include a release-note block. We need it to automatically generate changelogs, as @nibalizer kindly reminded. :)

leodido · 2020-12-14T09:19:41Z

rules/falco_rules.yaml

@@ -227,7 +227,7 @@
 - list: deb_binaries
  items: [dpkg, dpkg-preconfigu, dpkg-reconfigur, dpkg-divert, apt, apt-get, aptitude,
    frontend, preinst, add-apt-reposit, apt-auto-remova, apt-key,
-    apt-listchanges, unattended-upgr, apt-add-reposit, apt-config, apt-cache
+    apt-listchanges, unattended-upgr, apt-add-reposit, apt-config, apt-cache, apt.systemd.dai


Yup, but all the items' lengths are capped to 15 characters...

poiana · 2020-12-14T09:19:57Z

LGTM label has been added.

Git tree hash: e709e9f6336a66d1fbb299e245766f33854fa383

leogr · 2021-02-18T12:03:26Z

Hey,

I'm going to rebase this PR since a required check did not run. That should unblock this PR. I apologize for the inconvenience and for having taken so long.
We really appreciated your contribution.

Signed-off-by: Petr Michalec <epcim@apealive.net> Signed-off-by: Petr Michalec <pmichalec@ves.io>

poiana · 2021-02-18T12:07:18Z

LGTM label has been added.

Git tree hash: 0fb17d0933fef483c78653b2b558437676adb527

poiana · 2021-02-18T12:15:23Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leodido, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~rules/OWNERS~~ [leodido,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

poiana added kind/rule-update dco-signoff: no do-not-merge/release-note-label-needed labels Sep 8, 2020

poiana requested review from leodido and mfdii September 8, 2020 14:58

poiana added the size/XS label Sep 8, 2020

epcim force-pushed the rhsm-cert branch from 966a7f6 to 1224303 Compare September 8, 2020 14:58

poiana added dco-signoff: yes and removed dco-signoff: no labels Sep 8, 2020

epcim force-pushed the rhsm-cert branch 2 times, most recently from 63c8d4b to b28db36 Compare September 8, 2020 15:02

epcim changed the title ~~rhsm cert updates~~ package manager launched makro - rhsm cert updates, apt Sep 8, 2020

krisnova added this to the 0.27.0 milestone Sep 24, 2020

poiana requested a review from Kaizhe October 13, 2020 13:27

poiana added the area/rules label Nov 2, 2020

nibalizer reviewed Dec 12, 2020

View reviewed changes

leodido previously approved these changes Dec 14, 2020

View reviewed changes

poiana assigned leodido Dec 14, 2020

poiana added the lgtm label Dec 14, 2020

poiana added the approved label Dec 14, 2020

poiana removed the do-not-merge/release-note-label-needed label Dec 14, 2020

leogr previously approved these changes Dec 14, 2020

View reviewed changes

poiana assigned leogr Dec 14, 2020

fntlnz modified the milestones: 0.27.0, 0.28.0 Jan 15, 2021

fntlnz previously approved these changes Jan 19, 2021

View reviewed changes

poiana assigned fntlnz Jan 19, 2021

Kaizhe previously approved these changes Feb 17, 2021

View reviewed changes

poiana assigned Kaizhe Feb 17, 2021

Kaizhe removed the request for review from mfdii February 17, 2021 20:40

rhsm cert updates

da67bc8

Signed-off-by: Petr Michalec <epcim@apealive.net> Signed-off-by: Petr Michalec <pmichalec@ves.io>

leogr dismissed stale reviews from Kaizhe, fntlnz, leodido, and themself via da67bc8 February 18, 2021 12:06

leogr force-pushed the rhsm-cert branch from b28db36 to da67bc8 Compare February 18, 2021 12:06

poiana removed lgtm approved labels Feb 18, 2021

leogr approved these changes Feb 18, 2021

View reviewed changes

poiana added the lgtm label Feb 18, 2021

poiana added the approved label Feb 18, 2021

leogr requested review from nibalizer, leodido, Kaizhe and fntlnz February 18, 2021 12:15

leodido approved these changes Feb 18, 2021

View reviewed changes

poiana merged commit 5418451 into falcosecurity:master Feb 18, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

package manager launched makro - rhsm cert updates, apt #1385

package manager launched makro - rhsm cert updates, apt #1385

epcim commented Sep 8, 2020 •

edited by leodido

Loading

epcim commented Sep 8, 2020

leodido commented Sep 8, 2020 •

edited

Loading

leogr commented Oct 13, 2020

epcim commented Oct 19, 2020

epcim commented Oct 26, 2020

leogr commented Oct 27, 2020

epcim commented Nov 2, 2020

nibalizer commented Dec 12, 2020

nibalizer Dec 12, 2020

leodido Dec 14, 2020

epcim commented Dec 13, 2020 via email •

edited

Loading

leodido left a comment •

edited

Loading

leodido Dec 14, 2020

poiana commented Dec 14, 2020

leogr commented Feb 18, 2021

poiana commented Feb 18, 2021

poiana commented Feb 18, 2021

package manager launched makro - rhsm cert updates, apt #1385

package manager launched makro - rhsm cert updates, apt #1385

Conversation

epcim commented Sep 8, 2020 • edited by leodido Loading

epcim commented Sep 8, 2020

leodido commented Sep 8, 2020 • edited Loading

leogr commented Oct 13, 2020

epcim commented Oct 19, 2020

epcim commented Oct 26, 2020

leogr commented Oct 27, 2020

epcim commented Nov 2, 2020

nibalizer commented Dec 12, 2020

nibalizer Dec 12, 2020

Choose a reason for hiding this comment

leodido Dec 14, 2020

Choose a reason for hiding this comment

epcim commented Dec 13, 2020 via email • edited Loading

leodido left a comment • edited Loading

Choose a reason for hiding this comment

leodido Dec 14, 2020

Choose a reason for hiding this comment

poiana commented Dec 14, 2020

leogr commented Feb 18, 2021

poiana commented Feb 18, 2021

poiana commented Feb 18, 2021

epcim commented Sep 8, 2020 •

edited by leodido

Loading

leodido commented Sep 8, 2020 •

edited

Loading

epcim commented Dec 13, 2020 via email •

edited

Loading

leodido left a comment •

edited

Loading