Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append Slash to Sensitive Mount Path startswith #1394

Merged
merged 1 commit into from
Sep 11, 2020
Merged

Append Slash to Sensitive Mount Path startswith #1394

merged 1 commit into from
Sep 11, 2020

Conversation

bgeesaman
Copy link
Contributor

@bgeesaman bgeesaman commented Sep 10, 2020

What type of PR is this?

/kind bug
/kind rule-update

Any specific area of the project related to this PR?

/area rules

What this PR does / why we need it:
Make L#1932 equivalent to L#1898
The sensitive mount path at L#1932:

               container.image.repository startswith quay.io/sysdig) 

is missing an important trailing slash like in L#1898:

               container.image.repository startswith quay.io/sysdig/)

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

rule(macro falco_sensitive_mount_containers): Adds a trailing slash to avoid repo naming issues

@poiana
Copy link
Contributor

poiana commented Sep 10, 2020

Welcome @bgeesaman! It looks like this is your first PR to falcosecurity/falco 🎉

@poiana poiana added the size/XS label Sep 10, 2020
krisnova
krisnova previously approved these changes Sep 10, 2020
Copy link
Contributor

@krisnova krisnova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch - thank you

@poiana
Copy link
Contributor

poiana commented Sep 10, 2020

LGTM label has been added.

Git tree hash: 2f6fa8cccd120326ee5c843ec251b6097ac43bff

Make L#1932 equivalent to L#1898

Signed-off-by: Brad Geesaman <bradgeesaman+github@gmail.com>
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@leogr
Copy link
Member

leogr commented Sep 11, 2020

/milestone 0.26.0

@poiana poiana added this to the 0.26.0 milestone Sep 11, 2020
@poiana
Copy link
Contributor

poiana commented Sep 11, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leodido, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit cb2439d into falcosecurity:master Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants