Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: bump driver, sinsp and scap to 2aa88dcf6243982697811df4c1b484bcbe9488a2 #1410

Merged
merged 2 commits into from
Sep 18, 2020

Conversation

leogr
Copy link
Member

@leogr leogr commented Sep 18, 2020

What type of PR is this?

/kind bug

/kind cleanup

Any specific area of the project related to this PR?

/area build

What this PR does / why we need it:

This PR updates the sysdig version from draios/sysdig@73554b9 to draios/sysdig@2aa88dc so Falco can benefit from the latest fixes.

In details:

Which issue(s) this PR fixes:

Fixes #1409

Special notes for your reviewer:

N.B.
This PR aims to fix the problem that forced us to postpone the release (see https://lists.cncf.io/g/cncf-falco-dev/message/142)

/cc @fntlnz
/cc @leodido

Does this PR introduce a user-facing change?:

new: driver updated to 2aa88dcf6243982697811df4c1b484bcbe9488a2

See draios/sysdig#1684

Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@poiana poiana requested review from fntlnz and leodido September 18, 2020 13:26
@fntlnz fntlnz changed the title build: fix segfault and remove macrodefs about time update: bump driver, sinsp and scap to 2aa88dcf6243982697811df4c1b484bcbe9488a2 Sep 18, 2020
@poiana poiana added the size/XS label Sep 18, 2020
@fntlnz fntlnz changed the title update: bump driver, sinsp and scap to 2aa88dcf6243982697811df4c1b484bcbe9488a2 new: bump driver, sinsp and scap to 2aa88dcf6243982697811df4c1b484bcbe9488a2 Sep 18, 2020
@poiana
Copy link
Contributor

poiana commented Sep 18, 2020

LGTM label has been added.

Git tree hash: 7df71de9f93e1f2378ff7dff0cbd7fc74e16339a

@poiana
Copy link
Contributor

poiana commented Sep 18, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fntlnz
Copy link
Contributor

fntlnz commented Sep 18, 2020

/milestone 0.26.0

@poiana poiana added this to the 0.26.0 milestone Sep 18, 2020
@leodido leodido closed this Sep 18, 2020
@leodido leodido reopened this Sep 18, 2020
@poiana poiana merged commit 558b18e into master Sep 18, 2020
@poiana poiana deleted the fix/k8s-segfault branch September 18, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Falco 0.25.0-60+1efa4d3 - Segmentation fault (core dumped) when using K8s integration
4 participants