Falco to build on aarch64 #1442

fntlnz · 2020-10-13T11:46:48Z

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area build

What this PR does / why we need it:

What happens here:

libscap, libsinsp and drivers updated to the fntlnz-aarch64 branch, this is because we needed to add some preprocessor gates for aarch64. This needs to be changed with the specific commit id and SHA before merging aarch64 syscalls surface draios/sysdig#1701
luajit updated to git tag 1d8b747c161db457e032a023ebbff511f5de5ec2 - this is because luajit didn't tag since 2017, but they are actively developing it. Initially we wanted to switch to moonjit to support also ppc64le but the new luajit commits also address that along with the 64 bit changes needed for arm64. Please
gRPC updated to 1.32.0 read more
cpack fixes to produce aarch64 packees
CI build targets - opened an issue for this CI: pipeline, test and release targets for aarch64 and armv7 #1445

Which issue(s) this PR fixes:

Fixes #520

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

build: updated LuaJIT to 1d8b747c161db457e032a023ebbff511f5de5ec2
build: updated gRPC to v1.32.0
build: updated sinsp, scap and the drivers to 5c0b863ddade7a45568c0ac97d037422c9efb750
build: use fields_info from libsinsp
build: updated b64 to ce864b17ea0e24a91e77c7dd3eb2d1ac4175b3f0

fntlnz · 2020-10-13T11:48:47Z

This also supersedes the changes made for ppc64le #1225 since the only change needed here was to use moonjit instead of luajit. Many projects and OSes (like Alpine) already use moonjit as a synonim of luajit.

This will likely require some testing but the next release is on December 1st so there's no better time than now.

fntlnz · 2020-10-13T11:50:54Z

This PR also updates libsinsp and libscap, it's important to note that those already depend on moonjit for certain architectures and that there was a breaking change that needed to be addressed: draios/sysdig#1693

fntlnz · 2020-10-13T11:56:29Z

Note: 2.1.2 seems to be the latest moonjit that works for our lua code.

Tried to update to 2.2.0 and we start having issues. I know we want to start making plans to remove lua as we already did for the outputs in #1412 so I'll just note this here and we can follow up on that if we don't make such plan in the near future.

---
- required_engine_version: 7
# Currently disabled as read/write are ignored syscalls. The nearly
# similar open_write/open_read check for files being opened for
# reading/writing.
# - macro: write
#   condition: (syscall.type=write and fd.type in (file, directory))
# - macro: read
#   condition: (syscall.type=read and evt.dir=> and fd.type in (file, directory))
---. Exiting.

fntlnz · 2020-10-13T13:58:35Z

I switched back to Luajit but got the latest master. See details in the commit 0a08a04

poiana · 2020-10-15T16:23:00Z

LGTM label has been added.

Git tree hash: 38666a08c0d209db4431bccb4523719f66de4e8d

fntlnz · 2020-10-16T14:40:53Z

The minimal build fails are related to our sinsp dependency. Working on it draios/sysdig#1703

fntlnz · 2020-10-16T14:49:53Z

/hold

This is needed because Luajit does not support many architectures such as aarch64 and ppcle64. Note: some operating systems, such as Alpine, already use moonjit as a dropin replacement for luajit. Signed-off-by: Lorenzo Fontana <fontanalorenz@gmail.com>

Related-to: draios/sysdig#1693 Signed-off-by: Lorenzo Fontana <fontanalorenz@gmail.com>

Signed-off-by: Lorenzo Fontana <fontanalorenz@gmail.com>

moonjit is unmaintaned [0], and lujit recently [1] added support for the aarch64 architecture. [0] https://twitter.com/siddhesh_p/status/1308594269502885889?s=20 [1] LuaJIT/LuaJIT@e9af1ab Signed-off-by: Lorenzo Fontana <fontanalorenz@gmail.com>

Signed-off-by: Lorenzo Fontana <fontanalorenz@gmail.com>

Besides all the other improvements, we are really interested in getting the Make options for other ISAs than x86_64 when it comes to compiling abseil [0]. This is what happens on aarch64 ``` make[4]: *** [Makefile:2968: /root/falco/build-musl/grpc-prefix/src/grpc/objs/opt/third_party/abseil-cpp/absl/base/internal/thread_identity.o] Error 1 c++: error: unrecognized command line option '-maes' c++: error: unrecognized command line option '-msse4' c++: error: unrecognized command line option '-msse4' c++: error: unrecognized command line option '-maes' ``` [0] grpc/grpc@bf87ec9 Signed-off-by: Lorenzo Fontana <fontanalorenz@gmail.com>

…0c6c2cb2b8d08033 Signed-off-by: Lorenzo Fontana <fontanalorenz@gmail.com>

Signed-off-by: Lorenzo Fontana <fontanalorenz@gmail.com>

…037422c9efb750 Signed-off-by: Lorenzo Fontana <lo@linux.com>

fntlnz · 2020-11-07T18:05:07Z

/hold cancel

Ready for review

leogr

Just tried on an aarch64 instance with 18.04.5 LTS (Bionic Beaver).
It works nicely! 👏

poiana · 2020-11-09T14:39:10Z

LGTM label has been added.

Git tree hash: 9c0e213a6aa767f2bd46356c2d3ec416697bb734

leodido · 2020-11-10T09:04:45Z

cmake/modules/sysdig.cmake

@@ -57,6 +57,7 @@ add_subdirectory("${SYSDIG_SOURCE_DIR}/driver" "${PROJECT_BINARY_DIR}/driver")
 # Add libscap directory
 add_definitions(-D_GNU_SOURCE)
 add_definitions(-DHAS_CAPTURE)
+add_definitions(-DNOCURSESUI)


💯 finally!

leodido

Great job! 👏

Left a suggestion only

leodido · 2020-11-10T09:06:31Z

userspace/falco/CMakeLists.txt

    webserver.cpp
    grpc_context.cpp
    grpc_server_impl.cpp
    grpc_request_context.cpp
    grpc_server.cpp
+    webserver.cpp


Is this duplicate? See line 69

Suggested change

webserver.cpp

yes thanks!

leodido · 2020-11-10T09:08:01Z

userspace/falco/CMakeLists.txt


-add_dependencies(falco string-view-lite)
+  list(


Cool approach

poiana · 2020-11-10T09:08:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leodido, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [leodido,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

poiana added do-not-merge/work-in-progress release-note kind/feature dco-signoff: yes area/build labels Oct 13, 2020

poiana requested review from Kaizhe and mstemm October 13, 2020 11:46

poiana added the size/M label Oct 13, 2020

fntlnz force-pushed the build/aarch64 branch from 2601763 to 13837e0 Compare October 13, 2020 11:49

poiana added size/L and removed size/M labels Oct 13, 2020

fntlnz force-pushed the build/aarch64 branch from a099e23 to 13837e0 Compare October 13, 2020 11:54

fntlnz force-pushed the build/aarch64 branch from fa0d87c to 0a08a04 Compare October 13, 2020 13:55

fntlnz changed the title ~~wip: build on aarch64~~ wip: Falco to build on aarch64 Oct 15, 2020

fntlnz mentioned this pull request Oct 15, 2020

CI: pipeline, test and release targets for aarch64 and armv7 #1445

Closed

6 tasks

fntlnz changed the title ~~wip: Falco to build on aarch64~~ Falco to build on aarch64 Oct 15, 2020

poiana removed the do-not-merge/work-in-progress label Oct 15, 2020

leodido previously approved these changes Oct 15, 2020

View reviewed changes

poiana assigned leodido Oct 15, 2020

poiana added the lgtm label Oct 15, 2020

poiana added the approved label Oct 15, 2020

poiana added the do-not-merge/hold label Oct 16, 2020

fntlnz dismissed leodido’s stale review via 11760a9 October 16, 2020 14:59

fntlnz and others added 11 commits November 7, 2020 19:01

build: use fields_info from libsinsp

6a9fdfc

Related-to: draios/sysdig#1693 Signed-off-by: Lorenzo Fontana <fontanalorenz@gmail.com>

update: bump sinsp and scap to fntlnz-aarch64

416b457

Signed-off-by: Lorenzo Fontana <fontanalorenz@gmail.com>

update: syscall table zero definition for arm64

d597967

Signed-off-by: Lorenzo Fontana <fontanalorenz@gmail.com>

build: switch Falco back to luajit

efac824

moonjit is unmaintaned [0], and lujit recently [1] added support for the aarch64 architecture. [0] https://twitter.com/siddhesh_p/status/1308594269502885889?s=20 [1] LuaJIT/LuaJIT@e9af1ab Signed-off-by: Lorenzo Fontana <fontanalorenz@gmail.com>

update: cpack specify architecture for debian packages

0f1f8b8

Signed-off-by: Lorenzo Fontana <fontanalorenz@gmail.com>

build: update sinsp, scap and the drivers to c4f096099bf81966803d26c4…

cdb82dd

…0c6c2cb2b8d08033 Signed-off-by: Lorenzo Fontana <fontanalorenz@gmail.com>

build: cmake modules fixes and split

faced09

Signed-off-by: Lorenzo Fontana <fontanalorenz@gmail.com>

fix(userspace/falco): include directories and sources

066e67f

Signed-off-by: Lorenzo Fontana <fontanalorenz@gmail.com>

build: bump sinsp, scap and the drivers to 5c0b863ddade7a45568c0ac97d…

5e03ffb

…037422c9efb750 Signed-off-by: Lorenzo Fontana <lo@linux.com>

fntlnz force-pushed the build/aarch64 branch from dd33029 to 5e03ffb Compare November 7, 2020 18:04

poiana removed the do-not-merge/hold label Nov 7, 2020

leogr approved these changes Nov 9, 2020

View reviewed changes

poiana assigned leogr Nov 9, 2020

poiana added the lgtm label Nov 9, 2020

poiana added the approved label Nov 9, 2020

leodido reviewed Nov 10, 2020

View reviewed changes

leodido approved these changes Nov 10, 2020

View reviewed changes

poiana merged commit 55a93bc into master Nov 10, 2020

poiana added the do-not-merge/hold label Nov 10, 2020

poiana deleted the build/aarch64 branch November 10, 2020 09:09

This was referenced Nov 10, 2020

build: remove duplicate item from FALCO_SOURCES #1480

Merged

feat: Adding falco helm charts and configuration xunholy/k8s-gitops#152

Closed

ktsakalozos mentioned this pull request Apr 2, 2021

falco-addon canonical/microk8s#1922

Closed

2 tasks

morriq mentioned this pull request Dec 5, 2021

falco - wait on arm64 support morriq/kubernetes-raspberry4b#3

Open

medyagh mentioned this pull request Jan 12, 2022

ISO: Upgrade falco-module to version 0.28.0 kubernetes/minikube#13331

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Falco to build on aarch64 #1442

Falco to build on aarch64 #1442

fntlnz commented Oct 13, 2020 •

edited

Loading

fntlnz commented Oct 13, 2020

fntlnz commented Oct 13, 2020

fntlnz commented Oct 13, 2020

fntlnz commented Oct 13, 2020

poiana commented Oct 15, 2020

fntlnz commented Oct 16, 2020

fntlnz commented Oct 16, 2020

fntlnz commented Nov 7, 2020

leogr left a comment

poiana commented Nov 9, 2020

leodido Nov 10, 2020

leodido left a comment

leodido Nov 10, 2020

fntlnz Nov 10, 2020

leodido Nov 10, 2020

poiana commented Nov 10, 2020

Falco to build on aarch64 #1442

Falco to build on aarch64 #1442

Conversation

fntlnz commented Oct 13, 2020 • edited Loading

fntlnz commented Oct 13, 2020

fntlnz commented Oct 13, 2020

fntlnz commented Oct 13, 2020

fntlnz commented Oct 13, 2020

poiana commented Oct 15, 2020

fntlnz commented Oct 16, 2020

fntlnz commented Oct 16, 2020

fntlnz commented Nov 7, 2020

leogr left a comment

Choose a reason for hiding this comment

poiana commented Nov 9, 2020

leodido Nov 10, 2020

Choose a reason for hiding this comment

leodido left a comment

Choose a reason for hiding this comment

leodido Nov 10, 2020

Choose a reason for hiding this comment

fntlnz Nov 10, 2020

Choose a reason for hiding this comment

leodido Nov 10, 2020

Choose a reason for hiding this comment

poiana commented Nov 10, 2020

fntlnz commented Oct 13, 2020 •

edited

Loading