Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate Debian/RPM package from init to systemd #1448

Merged
merged 5 commits into from
Mar 12, 2021
Merged

feat: migrate Debian/RPM package from init to systemd #1448

merged 5 commits into from
Mar 12, 2021

Conversation

jenting
Copy link
Contributor

@jenting jenting commented Oct 16, 2020

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area build

What this PR does / why we need it:

Current Linux Os migrates from init to systemd, so we update the Falco Debian/RPM packages to systemd also.

Which issue(s) this PR fixes:

Fixes #1265

Special notes for your reviewer:

  • tested on Ubuntu Focal

    mkdir -p build
    cd build
    cmake ..
    make package
    ls *.deb | xargs dpkg -i
    /usr/bin/falco-driver-loader
    systemctl status falco.service
    systemctl start falco.service
    systemctl status falco.service
    
  • tested on CentOS 8 & openSUSE Leap 15.2

    mkdir -p build
    cd build
    cmake ..
    make package
    ls *.rpm | xargs rpm -i
    /usr/bin/falco-driver-loader
    systemctl status falco.service
    systemctl start falco.service
    systemctl status falco.service
    

Does this PR introduce a user-facing change?:

update: Debian/RPM package migrated from init to systemd
BREAKING CHANGE: the init.d service unit is not shipped anymore in deb/rpm packages in favor of a systemd service file

@poiana
Copy link
Contributor

poiana commented Oct 16, 2020

Welcome @jenting! It looks like this is your first PR to falcosecurity/falco 🎉

@poiana poiana added the size/L label Oct 16, 2020
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

Could we do the same thing for the DEB package too?

@jenting
Copy link
Contributor Author

jenting commented Oct 16, 2020

Thank you for your contribution!

Could we do the same thing for the DEB package too?

np! Let me make some code change and test on a Debian-based operating system.

@jenting jenting changed the title Migrate RPM package to systemd wip: Migrate RPM package to systemd Oct 16, 2020
@jenting jenting marked this pull request as draft October 16, 2020 12:48
@poiana poiana added size/XL and removed size/L labels Oct 19, 2020
@jenting jenting changed the title wip: Migrate RPM package to systemd wip: Migrate Debian/RPM package from init to systemd Oct 19, 2020
@jenting jenting marked this pull request as ready for review October 19, 2020 03:16
@jenting jenting changed the title wip: Migrate Debian/RPM package from init to systemd Migrate Debian/RPM package from init to systemd Oct 19, 2020
@jenting jenting changed the title Migrate Debian/RPM package from init to systemd wip: Migrate Debian/RPM package from init to systemd Oct 19, 2020
@jenting jenting changed the title wip: Migrate Debian/RPM package from init to systemd Migrate Debian/RPM package from init to systemd Oct 19, 2020
@jenting jenting requested a review from leogr October 19, 2020 13:00
@jenting
Copy link
Contributor Author

jenting commented Oct 19, 2020

Ready to be reviewed 🚀

scripts/debian/falco.service Outdated Show resolved Hide resolved
scripts/rpm/falco.service Outdated Show resolved Hide resolved
@leogr
Copy link
Member

leogr commented Oct 20, 2020

/milestone 0.27.0

@poiana poiana added this to the 0.27.0 milestone Oct 20, 2020
@poiana poiana requested a review from leodido October 29, 2020 14:18
@jenting jenting changed the title Migrate Debian/RPM package from init to systemd feat: migrate Debian/RPM package from init to systemd Nov 5, 2020
Copy link
Contributor

@fntlnz fntlnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for your PR and the interest in bringing this up. I have a major comment

scripts/debian/falco.service Show resolved Hide resolved
JenTing Hsiao added 5 commits February 4, 2021 14:53
Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>
Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>
Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>
Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>
Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>
@jenting jenting requested a review from fntlnz February 4, 2021 07:26
@jenting
Copy link
Contributor Author

jenting commented Feb 4, 2021

This is ready to review.
Ping @fntlnz @leogr

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEB tested with Ubuntu 20.10 👍
RPM tested with CentOS 8 👍

LGTM!!! 👏

Thank you @jenting

/cc @fntlnz
/cc @leodido

@poiana
Copy link
Contributor

poiana commented Feb 22, 2021

LGTM label has been added.

Git tree hash: 4f76e27830f9bdbd8358c119cca9b6362c8519aa

@leodido
Copy link
Member

leodido commented Feb 24, 2021

/hold

Need to unblock @poiana

@poiana
Copy link
Contributor

poiana commented Mar 12, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fntlnz
Copy link
Contributor

fntlnz commented Mar 12, 2021

/hold cancel

@fntlnz
Copy link
Contributor

fntlnz commented Mar 12, 2021

I believe it's now time to drop support for init.d based systems now.

Thanks for your patience on this @jenting and for pushing this forward for almost 1.5 years!

I'm signaling this as a breaking change in the release notes.

@poiana poiana merged commit b1801c2 into falcosecurity:master Mar 12, 2021
@jenting jenting deleted the rpm-systemd branch March 12, 2021 09:54
@leogr
Copy link
Member

leogr commented Mar 12, 2021

👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate Debian packages to Systemd
6 participants