-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate Debian/RPM package from init to systemd #1448
Conversation
Welcome @jenting! It looks like this is your first PR to falcosecurity/falco 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
Could we do the same thing for the DEB package too?
np! Let me make some code change and test on a Debian-based operating system. |
Ready to be reviewed 🚀 |
/milestone 0.27.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thanks for your PR and the interest in bringing this up. I have a major comment
Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>
Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>
Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>
Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>
Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM label has been added. Git tree hash: 4f76e27830f9bdbd8358c119cca9b6362c8519aa
|
/hold Need to unblock @poiana |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fntlnz, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
I believe it's now time to drop support for init.d based systems now. Thanks for your patience on this @jenting and for pushing this forward for almost 1.5 years! I'm signaling this as a breaking change in the release notes. |
👏 |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
Current Linux Os migrates from
init
tosystemd
, so we update the Falco Debian/RPM packages tosystemd
also.Which issue(s) this PR fixes:
Fixes #1265
Special notes for your reviewer:
tested on Ubuntu Focal
tested on CentOS 8 & openSUSE Leap 15.2
Does this PR introduce a user-facing change?: