Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove duplicate item from FALCO_SOURCES #1480

Merged
merged 1 commit into from
Nov 10, 2020

Conversation

leodido
Copy link
Member

@leodido leodido commented Nov 10, 2020

Signed-off-by: Leonardo Di Donato leodidonato@gmail.com

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area build

What this PR does / why we need it:

Which issue(s) this PR fixes:

During review of #1442 I found a duplicate but then approved the PR rather than commenting it.

Thus, @poiana merged it before @fntlnz or I could apply this last fix.

Special notes for your reviewer:

NONE

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@leodido
Copy link
Member Author

leodido commented Nov 10, 2020

/cc @fntlnz

@poiana poiana requested a review from fntlnz November 10, 2020 09:15
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch ;)

@poiana
Copy link
Contributor

poiana commented Nov 10, 2020

LGTM label has been added.

Git tree hash: ba2d6e084debf70c9f28f29e493f95dae5a97f97

@leogr
Copy link
Member

leogr commented Nov 10, 2020

/milestone 0.27.0

@poiana poiana added this to the 0.27.0 milestone Nov 10, 2020
@poiana
Copy link
Contributor

poiana commented Nov 10, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 8d10a60 into master Nov 10, 2020
@poiana poiana deleted the leodido-rm-duplicate-cmakelists-falco branch November 10, 2020 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants