Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Falco container image to AWS ECR Public registry #1512

Merged
merged 6 commits into from
Jan 8, 2021

Conversation

leodido
Copy link
Member

@leodido leodido commented Dec 17, 2020

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area build

What this PR does / why we need it:

Opening this PR with @jonahjon.

The goal here is to publish the Falco containers images (both the master one and the release one) to the AWS ECR Public registry 📦

As proposed by @jonahjon during yesterday's community call.

In fact, as discussed, it can be very useful for our community to be able to download Falco container images from different registries, especially since the latest changes to the Docker Hub.

TODOs:

  • Publish container image (falcosecurity/falco:master) for the master branch
  • Publish container image (falcosecurity/falco:<version>) for the releases (git tags)
  • Make these steps depending on those publishing docker images to the Docker Hub
  • Obtain falcosecurity slug on the AWS ECR Public registry

The following steps could be added in a follow-up PR:

  • Publish container image (falcosecurity:falco-no-driver:master)
  • Publish container image (falcosecurity:falco-no-driver:<version>)
  • Publish container image (falcosecurity:falco-driver-loader:master)
  • Publish container image (falcosecurity:falco-driver-loader:<version>)

Which issue(s) this PR fixes:

NONE

Special notes for your reviewer:

Note this does not change the status of the container images published to Docker Hub, which remains "official support" as per docs.

Does this PR introduce a user-facing change?:

build: falcosecurity/falco:master also available on the AWS ECR Public registry
build: falcosecurity/falco:latest also available on the AWS ECR Public registry

leodido and others added 4 commits December 16, 2020 17:55
Co-authored-by: jonahjon <jonahjones094@gmail.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Co-authored-by: jonahjon <jonahjones094@gmail.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
…er) to AWS ECR Public

Co-authored-by: jonahjon <jonahjones094@gmail.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
…co development version

Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@leodido
Copy link
Member Author

leodido commented Dec 17, 2020

First available Falco container image here! https://gallery.ecr.aws/b4t6c0y6/falco 🎉

.circleci/config.yml Outdated Show resolved Hide resolved
Copy link
Member Author

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-review to prepare the changes to submit once the slug falcosecurity is ready

.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
jonahjon
jonahjon previously approved these changes Dec 17, 2020
@poiana
Copy link
Contributor

poiana commented Dec 17, 2020

LGTM label has been added.

Git tree hash: a402aeefe065722c171d368032d454ad1ee23ed2

Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
.circleci/config.yml Outdated Show resolved Hide resolved
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@leodido leodido changed the title wip: Publish Falco container images to AWS ECR Public registry Publish Falco container image to AWS ECR Public registry Dec 24, 2020
@poiana
Copy link
Contributor

poiana commented Jan 7, 2021

LGTM label has been added.

Git tree hash: bc5596c9a37a81e6aae11829347b1e71fb1420e6

@poiana poiana added the approved label Jan 7, 2021
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems good to me, but it'd be better to re-use the same docker build to have the same image digest, IMHO.

Is there any reason to push a different build? Am I missing something? 🤔

@leogr
Copy link
Member

leogr commented Jan 8, 2021

/milestone 0.27.0

@poiana poiana added this to the 0.27.0 milestone Jan 8, 2021
@leogr
Copy link
Member

leogr commented Jan 8, 2021

/hold
to get other pending PRs merged
feel free to un-hold at any time

@leodido
Copy link
Member Author

leodido commented Jan 8, 2021

@leogr it seems to me DLC (docker layer caching) is false by default (ref).

Anyway, we can always improve it (and I agree with your point about image SHA) later.

@leogr
Copy link
Member

leogr commented Jan 8, 2021

@leogr it seems to me DLC (docker layer caching) is false by default (ref).

Anyway, we can always improve it (and I agree with your point about image SHA) later.

Ok, got it. We can fix it later.

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold cancel

@poiana
Copy link
Contributor

poiana commented Jan 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit da4a5b1 into master Jan 8, 2021
@poiana poiana deleted the jonah-ci-aws-ecr-registry branch January 8, 2021 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants