-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish Falco container image to AWS ECR Public registry #1512
Conversation
Co-authored-by: jonahjon <jonahjones094@gmail.com> Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Co-authored-by: jonahjon <jonahjones094@gmail.com> Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
…er) to AWS ECR Public Co-authored-by: jonahjon <jonahjones094@gmail.com> Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
…co development version Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
First available Falco container image here! https://gallery.ecr.aws/b4t6c0y6/falco 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Self-review to prepare the changes to submit once the slug falcosecurity
is ready
LGTM label has been added. Git tree hash: a402aeefe065722c171d368032d454ad1ee23ed2
|
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
LGTM label has been added. Git tree hash: bc5596c9a37a81e6aae11829347b1e71fb1420e6
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems good to me, but it'd be better to re-use the same docker build to have the same image digest, IMHO.
Is there any reason to push a different build? Am I missing something? 🤔
/milestone 0.27.0 |
/hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold cancel
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fntlnz, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
Opening this PR with @jonahjon.
The goal here is to publish the Falco containers images (both the master one and the release one) to the AWS ECR Public registry 📦
As proposed by @jonahjon during yesterday's community call.
In fact, as discussed, it can be very useful for our community to be able to download Falco container images from different registries, especially since the latest changes to the Docker Hub.
TODOs:
falcosecurity/falco:master
) for themaster
branchfalcosecurity/falco:<version>
) for the releases (git tags)falcosecurity
slug on the AWS ECR Public registryThe following steps could be added in a follow-up PR:
falcosecurity:falco-no-driver:master
)falcosecurity:falco-no-driver:<version>
)falcosecurity:falco-driver-loader:master
)falcosecurity:falco-driver-loader:<version>
)Which issue(s) this PR fixes:
NONE
Special notes for your reviewer:
Note this does not change the status of the container images published to Docker Hub, which remains "official support" as per docs.
Does this PR introduce a user-facing change?: