-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: hardening flags #1604
build: hardening flags #1604
Conversation
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Co-authored-by: Lorenzo Fontana <lo@linux.com> Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
LGTM label has been added. Git tree hash: dbd93cf0c31416e740b6c8a61cd40bc6d522bff3
|
/hold |
/hold |
/honk |
@leogr: Unable to find goose. Have you checked the garden? In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold cancel |
/hold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fntlnz, leodido The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
This PR explicitly sets common hardening flags to be used by default for building Falco.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
I have opted for
-fstack-protector-strong
over-fstack-protector-all
to avoid any potential performance penalty (more info can be found 👉 here)Tested with gdb-peda
Does this PR introduce a user-facing change?: