Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: hardening flags #1604

Merged
merged 2 commits into from
Apr 22, 2021
Merged

build: hardening flags #1604

merged 2 commits into from
Apr 22, 2021

Conversation

leogr
Copy link
Member

@leogr leogr commented Apr 7, 2021

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area build

What this PR does / why we need it:

This PR explicitly sets common hardening flags to be used by default for building Falco.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

I have opted for -fstack-protector-strong over -fstack-protector-all to avoid any potential performance penalty (more info can be found 👉 here)

Tested with gdb-peda

gdb-peda$ checksec
CANARY    : ENABLED
FORTIFY   : ENABLED
NX        : ENABLED
PIE       : ENABLED
RELRO     : FULL

Does this PR introduce a user-facing change?:

build: enforcing hardening flags by default

Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Co-authored-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@poiana poiana added size/S and removed size/XS labels Apr 7, 2021
@leogr leogr changed the title wip: build: hardening flags build: hardening flags Apr 8, 2021
@leogr leogr added this to the 0.28.1 milestone Apr 9, 2021
@poiana
Copy link
Contributor

poiana commented Apr 19, 2021

LGTM label has been added.

Git tree hash: dbd93cf0c31416e740b6c8a61cd40bc6d522bff3

@leogr
Copy link
Member Author

leogr commented Apr 20, 2021

/hold
to let other PRs get merged

@leogr
Copy link
Member Author

leogr commented Apr 21, 2021

/hold

@leogr
Copy link
Member Author

leogr commented Apr 21, 2021

/honk

@poiana
Copy link
Contributor

poiana commented Apr 21, 2021

@leogr: Unable to find goose. Have you checked the garden?

In response to this:

/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leogr
Copy link
Member Author

leogr commented Apr 21, 2021

/hold cancel
/cc @fntlnz

@poiana poiana requested a review from fntlnz April 21, 2021 13:14
@leogr
Copy link
Member Author

leogr commented Apr 21, 2021

/hold

@poiana
Copy link
Contributor

poiana commented Apr 22, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leogr
Copy link
Member Author

leogr commented Apr 22, 2021

/hold cancel

@leogr leogr merged commit d0be6d9 into master Apr 22, 2021
@poiana poiana deleted the build/security-flags branch April 22, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants