Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid loose conditions in rules and macros #1620

Merged
merged 2 commits into from
Apr 19, 2021

Conversation

leogr
Copy link
Member

@leogr leogr commented Apr 15, 2021

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it:

This PR mitigates possible bypasses due to too loose conditions.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

rule(macro: python_running_sdchecks): macro removed
rule(Change thread namespace): remove python_running_sdchecks exception

leogr added 2 commits April 15, 2021 11:46
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@poiana poiana requested review from leodido and mstemm April 15, 2021 12:57
@poiana poiana added the size/S label Apr 15, 2021
@leogr leogr added this to the 0.28.1 milestone Apr 15, 2021
@leogr leogr changed the title wip: avoid loose conditions in rules and macros avoid loose conditions in rules and macros Apr 19, 2021
@leogr leogr requested review from fntlnz and Kaizhe April 19, 2021 11:32
@poiana poiana added the lgtm label Apr 19, 2021
@poiana
Copy link
Contributor

poiana commented Apr 19, 2021

LGTM label has been added.

Git tree hash: 69823b7e6d4ad3a9994f269be54344081e3c5849

@poiana
Copy link
Contributor

poiana commented Apr 19, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@poiana
Copy link
Contributor

poiana commented Apr 19, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit e95ab26 into master Apr 19, 2021
@poiana poiana deleted the fix/rules-with-week-conditions branch April 19, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants