move falco_hostnetwork_images list to k8s_audit_rules.yaml to avoid a warning #1681

leodido · 2021-06-21T09:24:32Z

Signed-off-by: Leonardo Di Donato leodidonato@gmail.com

What type of PR is this?

/kind cleanup

/kind rule-update

Any specific area of the project related to this PR?

/area rules

What this PR does / why we need it:

The falco_hostnetwork_images list is defined in falco_rules.yaml but it's unused in it.

This PR moves it to avoid the warning when using only falco_rules.yaml.

When reading rules content: 1 warnings:
list falco_hostnetwork_images not referred to by any rule/macro/list

Which issue(s) this PR fixes:

NONE

Special notes for your reviewer:

The falco_hostnetwork_images list is only used in k8s_audit_rules.yaml.

Does this PR introduce a user-facing change?:

rule(list falco_hostnetwork_images): moved to k8s_audit_rules.yaml to avoid a warning when usng falco_rules.yaml only

leodido · 2021-06-21T09:24:50Z

/milestone 0.30.0

leogr

falco_hostnetwork_images is used in k8s_audit_rules.yaml.

It is also used by some integration tests (it seems they are failing for this reason).

Not sure if it makes sense to move the list to the k8s_audit_rules.yaml or leaving it as is now 🤔

leodido · 2021-06-23T09:16:59Z

/hold

On Wed, 23 Jun 2021 at 10:53 Leonardo Grasso ***@***.***> wrote: ***@***.**** commented on this pull request. falco_hostnetwork_images is used in k8s_audit_rules.yaml <https://github.com/falcosecurity/falco/blob/d6690313a0bdb48ff5fcb94784b6dc8b3afe2445/rules/k8s_audit_rules.yaml#L158> . It is also used by some integration tests (it seems they are failing for this reason). Not sure if it makes sense to move the list to the k8s_audit_rules.yaml or leaving it as is now 🤔 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1681 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAA5J46D7M5DXGUPJSHJOK3TUGOHBANCNFSM47BF62MQ> .

-- L.

poiana · 2021-09-21T20:55:29Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

leogr · 2021-09-22T10:09:47Z

Hey @leodido

Sorry, I had lost track of this PR. Is there any other issue other than the failing tests? Otherwise, it SGTM.

leodido · 2021-09-22T10:41:01Z

Rebased

poiana · 2021-10-29T08:47:25Z

Stale issues rot after 30d of inactivity.

Mark the issue as fresh with /remove-lifecycle rotten.

Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle rotten

poiana · 2021-11-28T09:13:40Z

Rotten issues close after 30d of inactivity.

Reopen the issue with /reopen.

Mark the issue as fresh with /remove-lifecycle rotten.

Provide feedback via https://github.com/falcosecurity/community.
/close

poiana · 2021-11-28T09:13:43Z

@poiana: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue with /reopen.

Mark the issue as fresh with /remove-lifecycle rotten.

Provide feedback via https://github.com/falcosecurity/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

leogr · 2021-11-29T11:13:55Z

Hey @leodido

Unfortunately, I lost track of this. Not sure if the PR is still in a consistent state. Let me know if I can help.

leogr · 2022-01-24T10:36:19Z

/reopen

poiana · 2022-01-24T10:36:22Z

@leogr: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

The `falco_hostnetwork_images` list is unused. This PR removes it to avoid the warning. ```console When reading rules content: 1 warnings: list falco_hostnetwork_images not refered to by any rule/macro/list ``` Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>

Co-authored-by: Leonardo Grasso <me@leonardograsso.com> Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>

leogr · 2022-01-24T11:42:48Z

I've rebased this PR on the current master.

leogr · 2022-01-24T12:13:18Z

/remove-lifecycle rotten

Co-Authored-by: Jason Dellaluce <jasondellaluce@gmail.com> Signed-off-by: Leonardo Grasso <me@leonardograsso.com>

leogr · 2022-01-24T14:00:51Z

/milestone 0.31.0

leogr · 2022-01-24T14:01:22Z

/unhold

leogr

/approve

jasondellaluce

/approve

poiana · 2022-01-24T14:02:42Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasondellaluce, leodido, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [jasondellaluce,leodido,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

poiana added release-note dco-signoff: yes kind/cleanup kind/rule-update area/rules labels Jun 21, 2021

poiana requested review from fntlnz and mstemm June 21, 2021 09:24

poiana added approved size/S labels Jun 21, 2021

poiana added this to the 0.30.0 milestone Jun 21, 2021

Kaizhe previously approved these changes Jun 21, 2021

View reviewed changes

poiana assigned Kaizhe Jun 21, 2021

poiana added the lgtm label Jun 21, 2021

leogr reviewed Jun 23, 2021

View reviewed changes

poiana added the do-not-merge/hold label Jun 23, 2021

leodido dismissed Kaizhe’s stale review via 66a3729 June 23, 2021 16:41

leodido changed the title ~~remove falco_hostnetwork_images list (unused)~~ move falco_hostnetwork_images list to k8s_audit_rules.yaml to avoid a warning regarding falco_rules.yaml Jun 23, 2021

leodido changed the title ~~move falco_hostnetwork_images list to k8s_audit_rules.yaml to avoid a warning regarding falco_rules.yaml~~ move falco_hostnetwork_images list to k8s_audit_rules.yaml to avoid a warning Jun 23, 2021

leodido requested a review from leogr June 23, 2021 17:04

poiana added the lifecycle/stale label Sep 21, 2021

leodido force-pushed the leodido-remove-unused-list branch from 66a3729 to 594536f Compare September 22, 2021 10:40

leogr modified the milestones: 0.30.0, 0.31.0 Sep 28, 2021

poiana removed the lifecycle/stale label Oct 29, 2021

poiana added the lifecycle/rotten label Oct 29, 2021

poiana closed this Nov 28, 2021

poiana reopened this Jan 24, 2022

leodido and others added 2 commits January 24, 2022 12:42

update(rules): move falco_hostnetwork_images list to k8s audit rules

d3d3f57

Co-authored-by: Leonardo Grasso <me@leonardograsso.com> Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>

leogr force-pushed the leodido-remove-unused-list branch from 594536f to d3d3f57 Compare January 24, 2022 11:42

poiana removed the lifecycle/rotten label Jan 24, 2022

fix(test): falco_hostnetwork_images list is now in k8s_audit_rules.yaml

85dc62e

Co-Authored-by: Jason Dellaluce <jasondellaluce@gmail.com> Signed-off-by: Leonardo Grasso <me@leonardograsso.com>

poiana removed the do-not-merge/hold label Jan 24, 2022

leogr approved these changes Jan 24, 2022

View reviewed changes

poiana assigned leogr Jan 24, 2022

jasondellaluce approved these changes Jan 24, 2022

View reviewed changes

poiana assigned jasondellaluce Jan 24, 2022

poiana merged commit 9ae8d28 into master Jan 24, 2022

poiana deleted the leodido-remove-unused-list branch January 24, 2022 14:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

move falco_hostnetwork_images list to k8s_audit_rules.yaml to avoid a warning #1681

move falco_hostnetwork_images list to k8s_audit_rules.yaml to avoid a warning #1681

leodido commented Jun 21, 2021 •

edited

Loading

leodido commented Jun 21, 2021

leogr left a comment

leodido commented Jun 23, 2021 via email

poiana commented Sep 21, 2021

leogr commented Sep 22, 2021

leodido commented Sep 22, 2021

poiana commented Oct 29, 2021

poiana commented Nov 28, 2021

poiana commented Nov 28, 2021

leogr commented Nov 29, 2021

leogr commented Jan 24, 2022

poiana commented Jan 24, 2022

leogr commented Jan 24, 2022 •

edited

Loading

leogr commented Jan 24, 2022

leogr commented Jan 24, 2022

leogr commented Jan 24, 2022

leogr left a comment

jasondellaluce left a comment

poiana commented Jan 24, 2022

move falco_hostnetwork_images list to k8s_audit_rules.yaml to avoid a warning #1681

move falco_hostnetwork_images list to k8s_audit_rules.yaml to avoid a warning #1681

Conversation

leodido commented Jun 21, 2021 • edited Loading

leodido commented Jun 21, 2021

leogr left a comment

Choose a reason for hiding this comment

leodido commented Jun 23, 2021 via email

poiana commented Sep 21, 2021

leogr commented Sep 22, 2021

leodido commented Sep 22, 2021

poiana commented Oct 29, 2021

poiana commented Nov 28, 2021

poiana commented Nov 28, 2021

leogr commented Nov 29, 2021

leogr commented Jan 24, 2022

poiana commented Jan 24, 2022

leogr commented Jan 24, 2022 • edited Loading

leogr commented Jan 24, 2022

leogr commented Jan 24, 2022

leogr commented Jan 24, 2022

leogr left a comment

Choose a reason for hiding this comment

jasondellaluce left a comment

Choose a reason for hiding this comment

poiana commented Jan 24, 2022

leodido commented Jun 21, 2021 •

edited

Loading

leogr commented Jan 24, 2022 •

edited

Loading