Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update k8s rules #1760

Merged
merged 2 commits into from
Oct 29, 2021
Merged

Update k8s rules #1760

merged 2 commits into from
Oct 29, 2021

Conversation

sboschman
Copy link
Contributor

What type of PR is this?

/kind feature
/kind rule-update

Any specific area of the project related to this PR?

/area rules

What this PR does / why we need it:

This PR adds a few more default k8s service accounts to the known_sa_list (these service accounts belong to default k8s controllers, see docs https://kubernetes.io/docs/reference/command-line-tools-reference/kube-controller-manager/).

Not listed in the docs mentioned above are the coredns sa's. As CoreDNS is such an integral part of k8s I opted to list coredns and coredns-autoscaler sa's as well.

To make the sa list easier to view, imo, I formatted it as 1 item per line and ordered all entries alphabetically.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

rule(list known_sa_list): add coredns, coredns-autoscaler, endpointslicemirroring-controller, horizontal-pod-autoscaler, job-controller, node-controller (nodelifecycle), persistent-volume-binder, pv-protection-controller, pvc-protection-controller, root-ca-cert-publisher and service-account-controller as allowed service accounts in the kube-system namespace

Signed-off-by: Sverre Boschman <1142569+sboschman@users.noreply.github.com>
Signed-off-by: Sverre Boschman <1142569+sboschman@users.noreply.github.com>
@poiana
Copy link
Contributor

poiana commented Oct 26, 2021

LGTM label has been added.

Git tree hash: 60f93f3eeb8fda0c2bdf099ec1ce60779f64c363

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

/approve
/milestone 0.31.0

@poiana poiana added this to the 0.31.0 milestone Oct 29, 2021
@poiana
Copy link
Contributor

poiana commented Oct 29, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leogr, sboschman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 762500a into falcosecurity:master Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants