Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ubuntu image for driver-loader test #1764

Merged
merged 1 commit into from
Nov 3, 2021
Merged

Update ubuntu image for driver-loader test #1764

merged 1 commit into from
Nov 3, 2021

Conversation

mstemm
Copy link
Contributor

@mstemm mstemm commented Oct 25, 2021 •
edited by leogr
Loading

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

build: update CircleCI machine image for eBPF tests to a newer version of ubuntu

@poiana poiana requested review from krisnova and mfdii October 25, 2021 20:08
@mstemm
Update ubuntu image for driver-loader tests (20.04LTS)
9bb983a 
Update the ubuntu image for driver-loader/integration tests from
16.04LTS to 20.04LTS.

Signed-off-by: Mark Stemm <mark.stemm@gmail.com>
@mstemm mstemm force-pushed the update-circleci-machine-image branch from de9f5eb to 9bb983a Compare October 25, 2021 20:34
@mstemm mstemm changed the title Meaningless commit Update ubuntu image for driver-loader test Oct 25, 2021
leogr
leogr approved these changes Oct 28, 2021
View reviewed changes
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
/approve

N.B.: ubuntu-1604:202004-01 worked in the past because CircleCI was using a different VM with 4.15.0-1027-gcp_28. For some reason, they recently switched to 4.4.0-1105-aws which is not supported by our eBPF probe. Thanks to @FedeDP and @jasondellaluce for having helped review this PR.

@poiana poiana added the lgtm label Oct 28, 2021
@poiana
Copy link
Contributor

poiana commented Oct 28, 2021

LGTM label has been added.

Git tree hash: 3f8e53d69e823058eaf3aedbdeee481dd1253508

@leogr
Copy link
Member

leogr commented Oct 29, 2021

/milestone 0.31.0

@poiana poiana added this to the 0.31.0 milestone Oct 29, 2021
@leogr leogr mentioned this pull request Nov 2, 2021
Merged
@markjacksonfishing
Copy link
Contributor

/lgtm

@poiana
Copy link
Contributor

poiana commented Nov 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leogr, markyjackson-taulia, mstemm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit b33fb60 into master Nov 3, 2021
@poiana poiana deleted the update-circleci-machine-image branch November 3, 2021 15:49
@krisnova
Copy link
Contributor

krisnova commented Nov 3, 2021

/approve

@leogr leogr mentioned this pull request Nov 22, 2021
Merged
@leogr leogr mentioned this pull request Apr 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markjacksonfishing markjacksonfishing markjacksonfishing approved these changes

@leogr leogr leogr approved these changes

@leodido leodido leodido approved these changes

@krisnova krisnova Awaiting requested review from krisnova

@mfdii mfdii Awaiting requested review from mfdii

Assignees

@leodido leodido

@leogr leogr

@markjacksonfishing markjacksonfishing

Labels
approved area/tests dco-signoff: yes kind/cleanup lgtm release-note size/XS
Projects
None yet
Milestone
0.31.0
Development

Successfully merging this pull request may close these issues.
6 participants
@mstemm @poiana @leogr @markjacksonfishing @krisnova @leodido