update(build): bump FakeIt version #1797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
leodido
approved these changes
Nov 18, 2021
|
LGTM label has been added. Git tree hash: aafebd825cb06bd918755fddaf52460c8ab1f2b2
|
leogr
approved these changes
Nov 22, 2021
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jasondellaluce, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/milestone 0.31.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jason Dellaluce jasondellaluce@gmail.com
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area build
/area tests
What this PR does / why we need it:
While working on the unit tests for #1792, I discovered that our
FakeItmocking lib is currently broken due to an incompatibility with the version ofCatch2our cmake setup depends on.Even though FakeIt is not used by our unit tests yet, I still believe this is a blocker for the future improvements of our testing suite.
The issue was caused by a macro renaming happened in
Catch2. After doing some research, this PR seems to fix it: eranpeer/FakeIt#195Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: