Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ECR repository to rules #1817

Merged
merged 2 commits into from
Dec 10, 2021
Merged

Add ECR repository to rules #1817

merged 2 commits into from
Dec 10, 2021

Conversation

calvinbui
Copy link
Contributor

@calvinbui calvinbui commented Dec 10, 2021

Signed-off-by: Calvin Bui 3604363+calvinbui@users.noreply.github.com

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

rules: add the official Falco ECR repository to rules

Signed-off-by: Calvin Bui <3604363+calvinbui@users.noreply.github.com>
@poiana
Copy link
Contributor

poiana commented Dec 10, 2021

Welcome @calvinbui! It looks like this is your first PR to falcosecurity/falco 🎉

Signed-off-by: Calvin Bui <3604363+calvinbui@users.noreply.github.com>
@Kaizhe
Copy link
Contributor

Kaizhe commented Dec 10, 2021

@leogr ,do we build the falco image for the public.ecr.aws registry?

@calvinbui
Copy link
Contributor Author

@Kaizhe
Copy link
Contributor

Kaizhe commented Dec 10, 2021

Copy link
Contributor

@Kaizhe Kaizhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@poiana
Copy link
Contributor

poiana commented Dec 10, 2021

LGTM label has been added.

Git tree hash: 2f213196c3f7f6affd579b732e5fa898be94dba0

@leogr
Copy link
Member

leogr commented Dec 10, 2021

Closing and reopening to trigger the CI
/close

@poiana poiana closed this Dec 10, 2021
@poiana
Copy link
Contributor

poiana commented Dec 10, 2021

@leogr: Closed this PR.

In response to this:

Closing and reopening to trigger the CI
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leogr
Copy link
Member

leogr commented Dec 10, 2021

/reopen

@poiana poiana reopened this Dec 10, 2021
@poiana
Copy link
Contributor

poiana commented Dec 10, 2021

@leogr: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leogr
Copy link
Member

leogr commented Dec 10, 2021

/milestone 0.31.0

@poiana poiana added this to the 0.31.0 milestone Dec 10, 2021
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thank you!

@poiana
Copy link
Contributor

poiana commented Dec 10, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: calvinbui, Kaizhe, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit cd471a7 into falcosecurity:master Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants