Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove apt-config utility from debian_packages monitoring #1860

Merged

Conversation

Andreagit97
Copy link
Member

Signed-off-by: Andrea Terzolo andrea.terzolo@polito.it

What type of PR is this?

/kind rule-update

Any specific area of the project related to this PR?

/area rules

What this PR does / why we need it:

As suggested by @karthikc911 we could avoid several false positives by removing the apt-config utility from debian packages monitoring list. I open this PR only because it could be useful to have it merged in Falco 0.31 but @karthikc911 had the original idea. For more details refer to the original Pull Request or to the slack channel.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

rule(list deb_binaries): remove `apt-config`

Signed-off-by: Andrea Terzolo <andrea.terzolo@polito.it>
Co-authored-by: karthikc911 <ckinnovative@gmail.com>
@Andreagit97 Andreagit97 force-pushed the remove_monitoring_of_apt-config branch from e89d794 to a6c4fa3 Compare January 19, 2022 16:56
@leogr
Copy link
Member

leogr commented Jan 20, 2022

/milestone 0.31.0

@poiana poiana added this to the 0.31.0 milestone Jan 20, 2022
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jan 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Jan 20, 2022

LGTM label has been added.

Git tree hash: 7677aa6385582f8b0e256ca21a1af2846c285622

@poiana poiana merged commit 18c7b65 into falcosecurity:master Jan 20, 2022
@Andreagit97 Andreagit97 deleted the remove_monitoring_of_apt-config branch October 15, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants