Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(userspace/falco): fix punctuation typo in output message when loading plugins #2026

Merged
merged 1 commit into from
May 30, 2022

Conversation

alacuku
Copy link
Member

@alacuku alacuku commented May 30, 2022

Signed-off-by: Aldo Lacuku <aldo@lacuku.eu>

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it:

Fix punctuation typo in output message when loading plugins.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

…oading plugins

Signed-off-by: Aldo Lacuku <aldo@lacuku.eu>
@poiana
Copy link
Contributor

poiana commented May 30, 2022

Welcome @alacuku! It looks like this is your first PR to falcosecurity/falco 🎉

@poiana poiana requested review from krisnova and mfdii May 30, 2022 07:16
@poiana poiana added the size/XS label May 30, 2022
@jasondellaluce
Copy link
Contributor

/ok-to-test

Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented May 30, 2022

LGTM label has been added.

Git tree hash: 551bef1c431f38e5a9f7dfa2d22b3fa99aeed7ef

@leogr
Copy link
Member

leogr commented May 30, 2022

/milestone 0.32.0

Closing and reopening to trigger the CI

/close

@poiana poiana added this to the 0.32.0 milestone May 30, 2022
@poiana poiana closed this May 30, 2022
@poiana
Copy link
Contributor

poiana commented May 30, 2022

@leogr: Closed this PR.

In response to this:

/milestone 0.32.0

Closing and reopening to trigger the CI

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leogr
Copy link
Member

leogr commented May 30, 2022

/reopen

@poiana
Copy link
Contributor

poiana commented May 30, 2022

@leogr: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana reopened this May 30, 2022
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented May 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, jasondellaluce, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jasondellaluce,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 765ef5d into falcosecurity:master May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants