Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(falco-scripts): remove driver versions with dkms-3.0.3 #2027

Merged
merged 1 commit into from
May 30, 2022

Conversation

Andreagit97
Copy link
Member

Signed-off-by: Andrea Terzolo andrea.terzolo@polito.it

What type of PR is this?

/kind bug

/kind feature

Any specific area of the project related to this PR?

/area build

What this PR does / why we need it:

New versions of dkms have a new format for dkms status -m:

module/version: added

The other two formats that we support (as said in #1950) are:

module, version, kernel, architecture: installed
module/version, kernel, architecture: installed

With this PR we should support all dkms formats, we will see in the next future if a new format will come out...

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Andrea Terzolo <andrea.terzolo@polito.it>
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

I have been experiencing the issue you described in my Arch, so thank you for the fix 🙏

/milestone 0.32.0
/approve

@poiana poiana added this to the 0.32.0 milestone May 30, 2022
@poiana poiana added the lgtm label May 30, 2022
@poiana
Copy link
Contributor

poiana commented May 30, 2022

LGTM label has been added.

Git tree hash: f2d8829dc0cf1e87e323f038f3d51e4440f936e1

Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented May 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, jasondellaluce, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jasondellaluce,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 9392c02 into falcosecurity:master May 30, 2022
@Andreagit97 Andreagit97 deleted the fix_driver_loader_script branch October 15, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants