Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(rules): cleanup rules - 4 #2179

Merged
merged 3 commits into from
Sep 1, 2022

Conversation

incertum
Copy link
Contributor

@incertum incertum commented Aug 28, 2022

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind release

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

/area CI

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

rule(Program run with disallowed http proxy env)!: disabled by default
rule(Container Drift Detected (chmod))!: disabled by default
rule(Container Drift Detected (open+create))!: disabled by default
rule(Packet socket created in container)!: removed consider_packet_socket_communication macro
rule(macro: consider_packet_socket_communication)!: remove unused macro
update(rules/falco_rules.yaml): `required_engine_version` changed to 13

Signed-off-by: Melissa Kilby <melissa.kilby.oss@gmail.com>
Signed-off-by: Melissa Kilby <melissa.kilby.oss@gmail.com>
Signed-off-by: Melissa Kilby <melissa.kilby.oss@gmail.com>
@poiana poiana requested review from darryk10 and leodido August 28, 2022 19:02
@poiana poiana added the size/S label Aug 28, 2022
@incertum incertum changed the title Cleanup rules 4 cleanup(rules): cleanup rules - 4 Aug 28, 2022
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

These were not easy to spot 😄 . Thanks!

@poiana
Copy link
Contributor

poiana commented Aug 29, 2022

LGTM label has been added.

Git tree hash: d21df86029d04e5f2c73337af1ec7af6ea4d17c2

@poiana
Copy link
Contributor

poiana commented Aug 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: incertum, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leogr
Copy link
Member

leogr commented Sep 1, 2022

/milestone 0.33.0

@poiana poiana added this to the 0.33.0 milestone Sep 1, 2022
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thank you

# Starting with version 8, the Falco engine supports exceptions.
# However the Falco rules file does not use them by default.
- required_engine_version: 9
- required_engine_version: 13
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@poiana poiana merged commit 5dcc329 into falcosecurity:master Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants