fix(rules): add falco no-driver images to k8s_containers macro #2234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
|
/milestone 0.33.0 |
96 tasks
|
LGTM label has been added. Git tree hash: 4fb606e424b72d229bd8f427ec6e549a1657222a
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, jasondellaluce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind rule-update
Any specific area of the project related to this PR?
/area rules
What this PR does / why we need it:
This adds the falco-no-driver images to the whitelist of the
k8s_containersmacro. Now that the official helm chart use the no-driver image as default, and considering the latest fixes the the libsinsp's k8s metadata client, Falco started alerting theContact K8S API Server From Containerrule noisy due to it detecting its own calls to the API server.Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: