chore(scripts/falco-driver-loader): improve curl resiliency

[Dentrax]

Fixes #2334

Signed-off-by: Furkan furkan.turkal@trendyol.com

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind release

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

/area CI

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #2334

Special notes for your reviewer:

I used --connect-timeout 5, --retry 3, --max-time 60 and --retry-max-time 120: curl will retry transient errors up to 3 times, each attempt is capped to 60 second, total time allowed for retries is 120 seconds and maximum time to allow for connecting is 5 seconds. Otherwise, curl could sit for hours waiting for missing packets.

Is there any test script to run some test falco-driver-loader script? I tried to test manually but somehow couldn't run the script:

DRIVERS_REPO="https://download.falco.org/driver" DRIVER_NAME=falco DRIVER_VERSION=foo FALCO_VERSION=0.30.1 ./falco-driver-loader.sh module --download

It seems environments couldn't set correctly: Running falco-driver-loader for: falco version=@FALCO_VERSION@. Can you please help me on this if it works?

Does this PR introduce a user-facing change?:

update(scripts/falco-driver-loader): optimize the resiliency of module download script for air-gapped environments

[developer-guy]

not a maintainer but LGTM

[poiana]

@developer-guy: changing LGTM is restricted to collaborators

In response to this:

not a maintainer but LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[FedeDP]

Hi!

It seems environments couldn't set correctly: Running falco-driver-loader for: falco version=@FALCO_VERSION@. Can you please help me on this if it works?

Fact is, this is an automatically configured script by the build process (cmake).
So, to configure it, once you cloned the repo, a mkdir build && cd build && cmake .. is enough; you will find the script inside the build folder (under scripts/ folder).

BTW thank you very much for taking care of this!

[jasondellaluce]

/milestone 0.34.0

[FedeDP]

/approve

[poiana]

LGTM label has been added.

Git tree hash: adb63e0bd474371f213d0a190288912ee803acb7

[jasondellaluce]

/approve

/milestone 0.34.0

[poiana]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Dentrax, developer-guy, FedeDP, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [FedeDP,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment