Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): fetch version step, download rpms/debs, minor change #2519

Merged
merged 3 commits into from
Apr 28, 2023
Merged

fix(ci): fetch version step, download rpms/debs, minor change #2519

merged 3 commits into from
Apr 28, 2023

Conversation

LucaGuerra
Copy link
Contributor

@LucaGuerra LucaGuerra commented Apr 28, 2023 •
edited
Loading

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area CI

What this PR does / why we need it:

  • A new job fetch-version was added to detect the Falco version, but not all dependent jobs were updated.
  • Fixed downloading of artifacts since we were trying to use a wildcard which isn't really supported 😅
  • Minor fix (security best practice) with handling the secret

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@LucaGuerra
fix(ci): update fetch-version steps
803b0f2 
Signed-off-by: Luca Guerra <luca@guerra.sh>
@poiana poiana requested review from Kaizhe and mstemm April 28, 2023 10:05
FedeDP
FedeDP previously approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Apr 28, 2023
@poiana
Copy link
Contributor

poiana commented Apr 28, 2023

LGTM label has been added.

Git tree hash: 5b663efed2a7997307d4b5e2df1f2479968293f3

@FedeDP
Copy link
Contributor

FedeDP commented Apr 28, 2023

/milestone 0.35.0

Refs #2501

@poiana poiana added this to the 0.35.0 milestone Apr 28, 2023
@FedeDP
Copy link
Contributor

FedeDP commented Apr 28, 2023

/hold

@LucaGuerra
Copy link
Contributor Author

I think this change is right but not enough to fix the latest error though

@LucaGuerra
fix(ci): download artifacts one by one
511e370 
Signed-off-by: Luca Guerra <luca@guerra.sh>
@LucaGuerra
fix(ci): only add the secret key to env when necessary
383a850 
Signed-off-by: Luca Guerra <luca@guerra.sh>
@poiana poiana removed the lgtm label Apr 28, 2023
@poiana poiana requested a review from FedeDP April 28, 2023 10:45
@poiana poiana added size/M and removed size/XS labels Apr 28, 2023
@LucaGuerra LucaGuerra changed the title fix(ci): update fetch-version steps fix(ci): fetch version step, download rpms/debs, minor change Apr 28, 2023
@LucaGuerra
Copy link
Contributor Author

LucaGuerra commented Apr 28, 2023 •
edited
Loading

Added a couple more things:

  • fixed downloading of artifacts since we were trying to use a wildcard which isn't really supported 😅
  • minor change with the GPG_KEY env variable use, instead of using it in all jobs it's only imported in the two steps that actually use it. This is a security best practice but does not change the functionality of the jobs.

Andreagit97
Andreagit97 approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Apr 28, 2023
@poiana
Copy link
Contributor

poiana commented Apr 28, 2023

LGTM label has been added.

Git tree hash: 5c7b48d288e94c3d003b7fc4853aba5ad03f643c

FedeDP
FedeDP approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Thank you!

leogr
leogr approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@poiana
Copy link
Contributor

poiana commented Apr 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, leogr, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FedeDP
Copy link
Contributor

FedeDP commented Apr 28, 2023

/unhold

@poiana poiana merged commit 6650a4f into falcosecurity:master Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andreagit97 Andreagit97 Andreagit97 approved these changes

@FedeDP FedeDP FedeDP approved these changes

@leogr leogr leogr approved these changes

@Kaizhe Kaizhe Awaiting requested review from Kaizhe

@mstemm mstemm Awaiting requested review from mstemm

Assignees

@leogr leogr

@FedeDP FedeDP

@Andreagit97 Andreagit97

Labels
approved area/ci dco-signoff: yes kind/bug lgtm release-note-none size/M
Projects
Falco Roadmap
Archived in project
Milestone
0.35.0
Development

Successfully merging this pull request may close these issues.
5 participants
@LucaGuerra @poiana @FedeDP @leogr @Andreagit97