Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(cmake): bump Falco rules to 1.0.0 #2618

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

loresuso
Copy link
Member

@loresuso loresuso commented Jun 7, 2023

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area tests

/area proposals

/area CI

What this PR does / why we need it:
as per PR title

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

update(cmake): bump Falco rules to 1.0.0

@loresuso
Copy link
Member Author

loresuso commented Jun 7, 2023

cc @FedeDP

@FedeDP
Copy link
Contributor

FedeDP commented Jun 7, 2023

/milestone 0.35.0

@poiana poiana added this to the 0.35.0 milestone Jun 7, 2023
FedeDP
FedeDP previously approved these changes Jun 7, 2023
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jun 7, 2023

LGTM label has been added.

Git tree hash: ebf8eaf2d3b13a5c9be91ddc60ad36476477d1e2

@poiana poiana added the approved label Jun 7, 2023
@jasondellaluce
Copy link
Contributor

The hash seems to not be right 🤔

Signed-off-by: Lorenzo Susini <susinilorenzo1@gmail.com>
@loresuso loresuso force-pushed the update/bump-rules-1.0.0 branch from 815af74 to fd11df0 Compare June 7, 2023 08:00
@poiana poiana removed the lgtm label Jun 7, 2023
@poiana poiana requested a review from FedeDP June 7, 2023 08:00
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Jun 7, 2023
@poiana
Copy link
Contributor

poiana commented Jun 7, 2023

LGTM label has been added.

Git tree hash: be05b36a7a36a8ca8a141cfc90d6877a7c329a99

Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jun 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce, loresuso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [FedeDP,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 2ea6190 into falcosecurity:master Jun 7, 2023
@FedeDP FedeDP mentioned this pull request Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants