Relocate tools on Flatcar in BPF mode #2729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In falcosecurity#2043 we've added logic for relocating tools on Flatcar when running falco-driver-loader in kmod mode. This logic is relevant for BPF mode, too, which is currently broken on Flatcar. Call flatcar_relocate_tools in BPF mode, too. Signed-off-by: Johanan Liebermann <jliebermann@microsoft.com>
|
/milestone 0.36.0 |
|
LGTM label has been added. Git tree hash: db2fde1aadf56dbb838550aeb69c48f8d3d448d3
|
leogr
approved these changes
Aug 21, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, johananl, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2043 we've added logic for relocating tools on Flatcar when running falco-driver-loader in kmod mode. This logic is relevant for BPF mode, too, which is currently broken on Flatcar. Call flatcar_relocate_tools in BPF mode, too.
cc: @jepio
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
What this PR does / why we need it:
In #2043 we've added logic which ensures driver compilation works on Flatcar Container Linux. This logic was added for kmod only, and therefore BPF driver compilation is currently broken for Flatcar. This PR invokes the same logic in BPF mode, too, which fixes the problem.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?: