diff --git a/unit_tests/engine/test_add_source.cpp b/unit_tests/engine/test_add_source.cpp index a6fcc1604cc..2670dd1bbbc 100644 --- a/unit_tests/engine/test_add_source.cpp +++ b/unit_tests/engine/test_add_source.cpp @@ -31,7 +31,7 @@ namespace class test_ruleset_factory : public evttype_index_ruleset_factory { public: - test_ruleset_factory(std::shared_ptr factory): + explicit test_ruleset_factory(std::shared_ptr factory): evttype_index_ruleset_factory(factory) { ruleset = evttype_index_ruleset_factory::new_ruleset(); diff --git a/unit_tests/engine/test_alt_rule_loader.cpp b/unit_tests/engine/test_alt_rule_loader.cpp index f86e7a2a99a..18e98ff529a 100644 --- a/unit_tests/engine/test_alt_rule_loader.cpp +++ b/unit_tests/engine/test_alt_rule_loader.cpp @@ -124,7 +124,7 @@ class test_reader : public rule_loader::reader class test_ruleset : public evttype_index_ruleset { public: - test_ruleset(std::shared_ptr factory): + explicit test_ruleset(std::shared_ptr factory): evttype_index_ruleset(factory){}; virtual ~test_ruleset() = default; @@ -154,7 +154,7 @@ class test_ruleset : public evttype_index_ruleset class test_ruleset_factory : public filter_ruleset_factory { public: - test_ruleset_factory(std::shared_ptr factory): + explicit test_ruleset_factory(std::shared_ptr factory): m_filter_factory(factory) { } diff --git a/userspace/engine/evttype_index_ruleset.h b/userspace/engine/evttype_index_ruleset.h index 71e7c11df7b..7688c1bd8b9 100644 --- a/userspace/engine/evttype_index_ruleset.h +++ b/userspace/engine/evttype_index_ruleset.h @@ -35,7 +35,7 @@ limitations under the License. class evttype_index_ruleset: public filter_ruleset { public: - evttype_index_ruleset(std::shared_ptr factory); + explicit evttype_index_ruleset(std::shared_ptr factory); virtual ~evttype_index_ruleset(); void add( @@ -158,7 +158,7 @@ class evttype_index_ruleset: public filter_ruleset class evttype_index_ruleset_factory: public filter_ruleset_factory { public: - inline evttype_index_ruleset_factory( + inline explicit evttype_index_ruleset_factory( std::shared_ptr factory ): m_filter_factory(factory) { } diff --git a/userspace/engine/falco_common.h b/userspace/engine/falco_common.h index 7a4476f9f8f..b7ea9d67100 100644 --- a/userspace/engine/falco_common.h +++ b/userspace/engine/falco_common.h @@ -44,7 +44,7 @@ struct falco_exception : std::exception { } - falco_exception(std::string error_str) + explicit falco_exception(std::string error_str) { m_error_str = error_str; } diff --git a/userspace/engine/falco_engine.h b/userspace/engine/falco_engine.h index 9484d605412..3206584adc5 100644 --- a/userspace/engine/falco_engine.h +++ b/userspace/engine/falco_engine.h @@ -44,7 +44,7 @@ limitations under the License. class falco_engine { public: - falco_engine(bool seed_rng=true); + explicit falco_engine(bool seed_rng=true); virtual ~falco_engine(); // A given engine has a version which identifies the fields diff --git a/userspace/engine/filter_details_resolver.h b/userspace/engine/filter_details_resolver.h index 33d8acae97e..798285bf97b 100644 --- a/userspace/engine/filter_details_resolver.h +++ b/userspace/engine/filter_details_resolver.h @@ -57,7 +57,7 @@ class filter_details_resolver private: struct visitor : public libsinsp::filter::ast::expr_visitor { - visitor(filter_details& details) : + explicit visitor(filter_details& details) : m_details(details), m_expect_list(false), m_expect_macro(false), diff --git a/userspace/engine/rule_loader.h b/userspace/engine/rule_loader.h index 533f0eb57f6..e634f573d89 100644 --- a/userspace/engine/rule_loader.h +++ b/userspace/engine/rule_loader.h @@ -226,7 +226,7 @@ namespace rule_loader class result : public falco::load_result { public: - result(const std::string &name); + explicit result(const std::string &name); virtual ~result() = default; result(result&&) = default; result& operator = (result&&) = default; @@ -293,7 +293,7 @@ namespace rule_loader struct engine_version_info { engine_version_info() : ctx("no-filename-given"), version("0.0.0") { }; - engine_version_info(context &ctx); + explicit engine_version_info(context &ctx); ~engine_version_info() = default; engine_version_info(engine_version_info&&) = default; engine_version_info& operator = (engine_version_info&&) = default; @@ -329,7 +329,7 @@ namespace rule_loader // a default constructor. This allows it to be used // by falco_engine, which aliases the type. plugin_version_info(); - plugin_version_info(context &ctx); + explicit plugin_version_info(context &ctx); ~plugin_version_info() = default; plugin_version_info(plugin_version_info&&) = default; plugin_version_info& operator = (plugin_version_info&&) = default; @@ -345,7 +345,7 @@ namespace rule_loader */ struct list_info { - list_info(context &ctx); + explicit list_info(context &ctx); ~list_info() = default; list_info(list_info&&) = default; list_info& operator = (list_info&&) = default; @@ -364,7 +364,7 @@ namespace rule_loader */ struct macro_info { - macro_info(context &ctx); + explicit macro_info(context &ctx); ~macro_info() = default; macro_info(macro_info&&) = default; macro_info& operator = (macro_info&&) = default; @@ -384,7 +384,7 @@ namespace rule_loader */ struct rule_exception_info { - rule_exception_info(context &ctx); + explicit rule_exception_info(context &ctx); ~rule_exception_info() = default; rule_exception_info(rule_exception_info&&) = default; rule_exception_info& operator = (rule_exception_info&&) = default; @@ -429,7 +429,7 @@ namespace rule_loader */ struct rule_info { - rule_info(context &ctx); + explicit rule_info(context &ctx); ~rule_info() = default; rule_info(rule_info&&) = default; rule_info& operator = (rule_info&&) = default; @@ -461,7 +461,7 @@ namespace rule_loader struct rule_update_info { - rule_update_info(context &ctx); + explicit rule_update_info(context &ctx); ~rule_update_info() = default; rule_update_info(rule_update_info&&) = default; rule_update_info& operator = (rule_update_info&&) = default; diff --git a/userspace/falco/app/actions/process_events.cpp b/userspace/falco/app/actions/process_events.cpp index 45b4ff9606f..696e92443c4 100644 --- a/userspace/falco/app/actions/process_events.cpp +++ b/userspace/falco/app/actions/process_events.cpp @@ -43,7 +43,7 @@ using namespace falco::app::actions; class source_sync_context { public: - source_sync_context(falco::semaphore& s) + explicit source_sync_context(falco::semaphore& s) : m_finished(false), m_joined(false), m_semaphore(s) { } inline void finish() diff --git a/userspace/falco/app/restart_handler.h b/userspace/falco/app/restart_handler.h index e7082bdef42..fc8519f9a45 100644 --- a/userspace/falco/app/restart_handler.h +++ b/userspace/falco/app/restart_handler.h @@ -46,7 +46,7 @@ class restart_handler */ using watch_list_t = std::vector; - restart_handler( + explicit restart_handler( on_check_t on_check, const watch_list_t& watch_files = {}, const watch_list_t& watch_dirs = {}) diff --git a/userspace/falco/falco_semaphore.h b/userspace/falco/falco_semaphore.h index d49b7324aef..458dd436437 100644 --- a/userspace/falco/falco_semaphore.h +++ b/userspace/falco/falco_semaphore.h @@ -31,7 +31,7 @@ namespace falco /** * @brief Creates a semaphore with the given initial counter value */ - semaphore(int c = 0): count(c) {} + explicit semaphore(int c = 0): count(c) {} /** * @brief Increments the internal counter and unblocks acquirers diff --git a/userspace/falco/grpc_context.h b/userspace/falco/grpc_context.h index fd402821dda..20b4176b655 100644 --- a/userspace/falco/grpc_context.h +++ b/userspace/falco/grpc_context.h @@ -36,7 +36,7 @@ const std::string meta_request = "request_id"; class context { public: - context(::grpc::ServerContext* ctx); + explicit context(::grpc::ServerContext* ctx); virtual ~context() = default; void get_metadata(std::string key, std::string& val); @@ -49,7 +49,7 @@ class context class stream_context : public context { public: - stream_context(::grpc::ServerContext* ctx): + explicit stream_context(::grpc::ServerContext* ctx): context(ctx){}; virtual ~stream_context() = default; @@ -68,7 +68,7 @@ class stream_context : public context class bidi_context : public stream_context { public: - bidi_context(::grpc::ServerContext* ctx): + explicit bidi_context(::grpc::ServerContext* ctx): stream_context(ctx){}; virtual ~bidi_context() = default; }; diff --git a/userspace/falco/grpc_request_context.cpp b/userspace/falco/grpc_request_context.cpp index ec26d28120b..471de32a716 100644 --- a/userspace/falco/grpc_request_context.cpp +++ b/userspace/falco/grpc_request_context.cpp @@ -123,7 +123,7 @@ template<> void request_context::process(server* srv) { version::response res; - (srv->*m_process_func)(m_srv_ctx.get(), m_req, res); + (srv->*m_process_func)(context(m_srv_ctx.get()), m_req, res); // Notify the gRPC runtime that this processing is done m_state = request_context_base::FINISH; diff --git a/userspace/falco/versions_info.h b/userspace/falco/versions_info.h index 7316b90c5e6..c2085285a09 100644 --- a/userspace/falco/versions_info.h +++ b/userspace/falco/versions_info.h @@ -34,7 +34,7 @@ namespace falco * @brief Construct a versions info by using an inspector to obtain * versions about the drivers and the loaded plugins. */ - versions_info(const std::shared_ptr& inspector); + explicit versions_info(const std::shared_ptr& inspector); versions_info(versions_info&&) = default; versions_info& operator = (versions_info&&) = default; versions_info(const versions_info& s) = default; diff --git a/userspace/falco/yaml_helper.h b/userspace/falco/yaml_helper.h index 94a7779bd69..7b0dcab075f 100644 --- a/userspace/falco/yaml_helper.h +++ b/userspace/falco/yaml_helper.h @@ -42,7 +42,7 @@ class yaml_helper; class yaml_visitor { private: using Callback = std::function; - yaml_visitor(Callback cb): seen(), cb(std::move(cb)) {} + explicit yaml_visitor(Callback cb): seen(), cb(std::move(cb)) {} void operator()(YAML::Node &cur) { seen.push_back(cur);