Adding a macro for sdjagent.jar running inside agent container #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved versions of inbound/outbound macros that add coverage for recvfrom/recvmsg, sendto/sendmsg and also ignore non-blocking syscalls in a different way.
Process truncated due to comm limit. Also fix some parentheses for another write_etc_common macro.
Let prometheus-conf write its config below /etc/prometheus.
Currently, we make usage of the macro 'java_running_sdjagent', which relies on the process command line argument. We recently noticed that in certain cases, in a containerized environment, the process command line does not contain sdjagent.jar. Introducing the 'java_in_agent_container' macro and make use on the two rules that relied solely on the command line macro to avoid alerts. Adding a comment within the rule, to explain the need and usage of both macros.
|
Closing as we already merged most of the changes in #470. Let's create a separate PR just for the sdjagent changes, if we need them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.