Update the Puppet module #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Apply puppet-lint recommendations * Update the README since the project moved from draios to falcosecurity in GitHub * Move parameters in their own file + Add the DEB repository automatically + Add the EPEL repository automatically + Add a logrotate configuration * Update the configuration file with all the latest updates falco-CLA-1.0-contributing-entity: Coveo Solutions Inc. falco-CLA-1.0-signed-off-by: Jean-Philippe Lachance <jplachance@coveo.com>
mstemm
requested changes
Feb 19, 2019
* Set dependencies between classes * Set the class order * Apply mstemm's code review
* Use a working version of puppetlabs-apt * Use dependencies to be compatible with Puppet 4.7 and above
mstemm
approved these changes
Feb 21, 2019
mstemm
added a commit
that referenced
this pull request
Feb 21, 2019
0.2.0 was released as a part of testing an early version in #537, and can't be overwritten, so publish as 0.3.0.
Merged
mstemm
added a commit
that referenced
this pull request
Feb 21, 2019
0.2.0 was released as a part of testing an early version in #537, and can't be overwritten, so publish as 0.3.0.
leogr
pushed a commit
to falcosecurity/rules
that referenced
this pull request
Dec 21, 2022
0.2.0 was released as a part of testing an early version in falcosecurity/falco#537, and can't be overwritten, so publish as 0.3.0.
leogr
pushed a commit
to falcosecurity/rules
that referenced
this pull request
Dec 21, 2022
0.2.0 was released as a part of testing an early version in falcosecurity/falco#537, and can't be overwritten, so publish as 0.3.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings!
I noticed the Puppet module is a little outdated compared to this repository. I also noticed the installation was not working because the DEB repository was not managed by this module. This PR should fix that!
A list of the changes:
* Apply puppet-lint recommendations
* Update the README since the project moved from
draiostofalcosecurityin GitHub* Move parameters in their own file
+ Add the DEB repository automatically (based on https://github.com/garethr/garethr-sysdig/blob/master/manifests/install.pp)
+ Add the EPEL repository automatically (based on https://github.com/garethr/garethr-sysdig/blob/master/manifests/install.pp)
+ Add a
logrotateconfiguration* Update the configuration file with all the latest updates
🆘 Please note that I'm not a Puppet expert 😄
falco-CLA-1.0-contributing-entity: Coveo Solutions Inc.
falco-CLA-1.0-signed-off-by: Jean-Philippe Lachance jplachance@coveo.com