-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rule updates 2019 05.v1 #590
Conversation
Ensures a preceding not will apply to the whole macro
It looks like a lot of scripted programs (shell scripts running cp, sed, arbitrary ruby programs) are run by fluentd to set up config. They're too generic to identify, so jut add /etc/fluent/configs.d to safe_etc_dirs, sadly.
/opt/jboss/container/java/run/run-java.sh and /opt/run-java/run-java.sh write to /etc/passwd in a contaner, probably to add a user. Add an exception for them.
Could you add a fix for the FPs generated by |
@@ -1029,6 +1029,13 @@ | |||
fd.name startswith "/etc/rancher-dns") | |||
) | |||
|
|||
- macro: jboss_in_container_writing_passwd | |||
condition: > | |||
((proc.cmdline="run-java.sh /opt/jboss/container/java/run/run-java.sh" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the proc.cmdline
looks strange, the args[1]
is the abs path of the exe
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does look strange, but the policy event did have that as the full cmdline. Here's an example:
File below /etc opened for writing (user=<NA> command=run-java.sh /opt/jboss/container/java/run/run-java.sh parent=java pcmdline=java -javaagent:/opt/jboss/container/jolokia/jolokia.jar=config=/opt/jboss/container/jolokia/etc/jolokia.properties....
And for reference, the output field of that rule is:
output: "File below /etc opened for writing (user=%user.name command=%proc.cmdline parent=%proc.pname pcmdline=%proc.pcmdline file=%fd.name program=%proc.name gparent=%proc.aname[2] ggparent=%proc.aname[3] gggparent=%proc.aname[4])"
No description provided.