Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ash to the list of shell binaries #597

Merged
merged 1 commit into from
May 12, 2019

Conversation

semekh
Copy link
Contributor

@semekh semekh commented May 12, 2019

It is specifically used a lot in alpine-based images.

It is specifically used a lot in alpine-based images.

falco-CLA-1.0-signed-off-by: Mehran Kholdi <semekh@hamravesh.com>
@semekh semekh force-pushed the improvement/add-ash-to-shells branch from a7ecac4 to f365056 Compare May 12, 2019 15:44
Copy link
Contributor

@fntlnz fntlnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @semekh

@leodido leodido self-requested a review May 12, 2019 18:09
Copy link
Member

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting the CI to be green.

Thanks for the PR 👍

@fntlnz fntlnz merged commit 5736ed6 into falcosecurity:dev May 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants