Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: improve docs for new contributors #665

Merged
merged 1 commit into from
Jun 11, 2019
Merged

Conversation

fntlnz
Copy link
Contributor

@fntlnz fntlnz commented Jun 11, 2019

Signed-off-by: Lorenzo Fontana lo@linux.com

What type of PR is this?

/kind documentation

Any specific area of the project related to this PR?
No

What this PR does / why we need it:

We recently, in #644 we added a contributing file that deprecates the content in readme.

I also added the Falco logo to the readme to make the repo cute.

Which issue(s) this PR fixes:
No

Special notes for your reviewer:
Hello reviewer, be kind

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Lorenzo Fontana <lo@linux.com>
@fntlnz fntlnz force-pushed the feat/improve-docs-contributing branch from 5aff867 to 7705891 Compare June 11, 2019 23:46
@poiana
Copy link
Contributor

poiana commented Jun 11, 2019

LGTM label has been added.

Git tree hash: f78aaabb370a1c927b6778242273f285a90ead07

@poiana
Copy link
Contributor

poiana commented Jun 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 4b126fb into dev Jun 11, 2019
@poiana poiana deleted the feat/improve-docs-contributing branch June 11, 2019 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants