new: initial clang format file #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fntlnz
previously approved these changes
Jun 25, 2019
|
LGTM label has been added. Git tree hash: 24fcf335ffe8ac37e43489910685a91341486786
|
This coding convention's solely goal is to approximately match the current code style. It MUST not be intended in any other way until a real and definitive coding convention is put in. Co-authored-by: Lorenzo Fontana <lo@linux.com> Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
leodido
force-pushed
the
feat/setup-clang-format-file
branch
from
97c4f33 to
3c5e863
Compare
|
/lgtm |
|
LGTM label has been added. Git tree hash: 949584a420bdd54017ef6d9dd1a56235f4274dcb
|
fntlnz
approved these changes
Jun 25, 2019
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fntlnz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This coding convention's solely goal is to approximately match the current code style.
It MUST not be intended in any other way until a real and definitive coding convention is put in.
What type of PR is this?
/kind documentation
/kind feature
What this PR does / why we need it:
It simply adds an initial
.clang-formatcoding style file.This is the first step o a broader refactoring and cleanup me and @fntlnz intend to do.
Refer to the below linked issue for ideas, proposals, or just reference.
Also notice that this PR does not introduce any real enforcement of the coding style neither locally in the IDEs/editos neither via CI checks.
Which issue(s) this PR fixes:
Refs #688
Special notes for your reviewer:
Does this PR introduce a user-facing change?: