Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clang format following the current style #701

Merged
merged 1 commit into from
Jul 3, 2019
Merged

Conversation

fntlnz
Copy link
Contributor

@fntlnz fntlnz commented Jul 2, 2019

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind cleanup

Any specific area of the project related to this PR?

What this PR does / why we need it:

@mstemm pointed out that our new clang format wasn't really following the current code style.

We added a clang format created by @gianlucaborello that is better to match the current style and reformatted the files from #692

Which issue(s) this PR fixes:
NONE

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Lorenzo Fontana <lo@linux.com>

Co-authored-by: Leonardo Di Donato <leodidonato@gmail.com>
@fntlnz
Copy link
Contributor Author

fntlnz commented Jul 2, 2019

/assign @mstemm

@mstemm mstemm self-requested a review July 2, 2019 16:41
@poiana poiana added the lgtm label Jul 2, 2019
@poiana
Copy link
Contributor

poiana commented Jul 2, 2019

LGTM label has been added.

Git tree hash: 890270f3f46d8616ef427317c1e67ee40ce17730

@poiana poiana added the approved label Jul 2, 2019
@leodido leodido self-requested a review July 2, 2019 17:17
@poiana
Copy link
Contributor

poiana commented Jul 2, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leodido, mstemm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fntlnz fntlnz merged commit b2ef08f into dev Jul 3, 2019
@poiana poiana deleted the fix/clang-format branch July 3, 2019 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants