Write below root error triggering on GKE #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome @jonnymcgow7! It looks like this is your first PR to falcosecurity/falco 🎉 |
|
/lgtm |
|
LGTM label has been added. Git tree hash: 431eb40778170545935f002f0b38a1c1f75b440b
|
leodido
previously approved these changes
Jul 29, 2019
|
Thanks for sending this PR @jonnymcgow7 ! Would you please rebase it? :) - Nevermind, done by myself The Helm chart will be promptly updated with the next release (cc @nestorsalceda). |
GKE regularly calls /exec.fifo from both a system level, and within individual falco pods. As is this triggers errors multiple times every hour. This change adds /exec.fifo to the expected files below root that will be called. Signed-off-by: Jonathan McGowan <jonnymcgow7@gmail.com>
leodido
approved these changes
Jul 30, 2019
|
LGTM label has been added. Git tree hash: 70baf7eaf7590a35aadf59465daea255eb7ee031
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Kaizhe, leodido The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/assign @leodido
What type of PR is this?
/kind bug
/kind rule-update
Any specific area of the project related to this PR?
/area rules
What this PR does / why we need it:
GKE regularly calls /exec.fifo from both a system level, and within
individual falco pods. As is this triggers errors multiple times every
hour. This change adds /exec.fifo to the expected files below root that
will be called.
Which issue(s) this PR fixes:
Fixes #738
Special notes for your reviewer:
The rule update will need to be propagated to the helm chart on https://github.com/helm/charts/tree/master/stable/falco as well before the issue is resolved. I've cloned the helm/charts repo and have updated mine locally in the meantime to test and it has resolved the error for me.
Does this PR introduce a user-facing change?: