rules: strict checks on hidden files and repository files that are modified #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
needs-kind
kind/rule-update
area/rules
size/S
and removed
needs-kind
labels
fntlnz
changed the title
|
LGTM label has been added. Git tree hash: f7604229178be9c568a5199b605deee397393199
|
fntlnz
force-pushed
the
fix/modify-trigger
branch
from
3581fea to
9915013
Compare
fntlnz
force-pushed
the
fix/modify-trigger
branch
from
9915013 to
4cc1d10
Compare
|
/lgtm |
|
LGTM label has been added. Git tree hash: a694ec47a73fc4a888ac8e4f3d516d296100b3f6
|
leodido
previously approved these changes
Aug 16, 2019
… or created Signed-off-by: Lorenzo Fontana <lo@linux.com>
fntlnz
force-pushed
the
fix/modify-trigger
branch
from
4cc1d10 to
fa138bc
Compare
leodido
approved these changes
Aug 19, 2019
|
LGTM label has been added. Git tree hash: e950fc67927b1612c61d2e0f891707f279cbc2a2
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kris-nova, leodido The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lorenzo Fontana lo@linux.com
What type of PR is this?
/kind rule-update
Any specific area of the project related to this PR?
/area rules
What this PR does / why we need it:
In "Create Hidden Files or Directories", when a directory or a file is created the rule is triggered but it should also trigger when a file or directory is moved to become and hidden one, this PR uses the
modifymacro to do that additional check.In "Update Package Repository" when a directory or a file is updated in the sensitive packages folder the rule is triggered, however it was not triggered when a file is moved into those directories. This PR fixes that using the
modifymacro.Which issue(s) this PR fixes:
NONE
Special notes for your reviewer:
Does this PR introduce a user-facing change?: