Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the image name and tag for the linuxkit Dockerfile #913

Conversation

yashbhutwala
Copy link
Contributor

@yashbhutwala yashbhutwala commented Nov 4, 2019

What type of PR is this?

/kind bug
/kind cleanup

Any specific area of the project related to this PR?

/area build

What this PR does / why we need it:
fixes the image name and tag for the linuxkit Dockerfile

fix(docker/kernel/linuxkit): correct FROM for falco minimal image

@poiana
Copy link
Contributor

poiana commented Nov 4, 2019

Welcome @yashbhutwala! It looks like this is your first PR to falcosecurity/falco 🎉

leodido
leodido previously approved these changes Nov 4, 2019
@poiana
Copy link
Contributor

poiana commented Nov 4, 2019

LGTM label has been added.

Git tree hash: a45cbbffbd74c69397723a8893e7586909749a5d

@leodido
Copy link
Member

leodido commented Nov 4, 2019

Thanks for spotting this @yashbhutwala could you please edit your commit signing it?

Signed-off-by: Yash Bhutwala <ymb002@bucknell.edu>
@yashbhutwala
Copy link
Contributor Author

yashbhutwala commented Nov 4, 2019

Thanks for spotting this @yashbhutwala could you please edit your commit signing it?

Of course, and signed 😄

@leodido need another lgtm

@leodido leodido self-requested a review November 5, 2019 14:46
@leodido leodido merged commit 8c2a36c into falcosecurity:dev Nov 5, 2019
@poiana
Copy link
Contributor

poiana commented Nov 5, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the approved label Nov 5, 2019
@fntlnz fntlnz added this to the 0.19.0 milestone Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants