Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove references #922

Merged
merged 14 commits into from
Nov 14, 2019
Merged

Remove references #922

merged 14 commits into from
Nov 14, 2019

Conversation

leodido
Copy link
Member

@leodido leodido commented Nov 8, 2019

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

NONE

What this PR does / why we need it:

Removes some more unnecessary, legacy references to Falco in Sysdig.

Does this PR introduce a user-facing change?:

update(docker): use HOST_ROOT environment variable rather than SYSDIG_HOST_ROOT
update: EF_DROP_FALCO is now EF_DROP_SIMPLE_CONS
update: puppet module had been renamed from "sysdig-falco" to "falco"

ldegio and others added 13 commits November 8, 2019 14:28
@ldegio @leodido
chore: remove some more unnecessary, legacy references to falco in sy…
d219eed 
…sdig

Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Co-authored-by: Leonardo Di Donato <leodidonato@gmail.com>
@ldegio @leodido
new falco-probe-loader file that doesn't depend on sysdig
741b6b2 
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Co-authored-by: Leonardo Di Donato <leodidonato@gmail.com>
@ldegio @leodido
fix(scripts): license header
2e6dced 
Co-authored-by: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@ldegio @leodido
chore: naming cleanup
3da3030 
Co-authored-by: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@leodido
fix(userspace/falco): typo for consumer related methods
9a6281a 
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@leodido
fix(docker): glob rather than ls in the docker entrypoints
ddce8ac 
Plus, make them use HOST_ROOT env var, not SYSDIG_HOST_ROOT

Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@leodido
fix(scripts): rename SYSDIG_HOST_ROOT env variable into HOST_ROOT
2ac1ff5 
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@leodido
fix(docker): adapt dockerfiles to HOST_ROOT env var
1159fe4 
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@leodido @fntlnz
update(docker): introduce SKIP_MODULE_LOAD env variable
2a5f3a3 
Co-authored-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@leodido @fntlnz
update(scripts): rename env variables for falco probe loader
10ffb9a 
Co-authored-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@leodido
chore: improving naming
79ea25b 
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@leodido @fntlnz
update: puppet module had been renamed to falco
2e4411b 
Co-authored-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@leodido @fntlnz
chore: removing sysdig references
9b572d9 
Co-authored-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@poiana poiana requested review from krisnova and mstemm November 8, 2019 14:32
@leodido leodido requested review from fntlnz and removed request for mstemm and krisnova November 8, 2019 14:33
@poiana poiana added the size/XXL label Nov 8, 2019
@leodido leodido mentioned this pull request Nov 8, 2019
Closed
@leodido @fntlnz
fix(scripts): copy falco-probe-loader during packages build
9e113d1 
Co-authored-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@krisnova
Copy link
Contributor

/lgtm
/approve

@poiana poiana added the lgtm label Nov 12, 2019
@poiana
Copy link
Contributor

poiana commented Nov 12, 2019

LGTM label has been added.

Git tree hash: 109c629744eba87b3bb297df2fdd054d88071f71

@mfdii
Copy link
Member

mfdii commented Nov 12, 2019

/lgtm

@fntlnz fntlnz mentioned this pull request Nov 12, 2019
Closed
@fntlnz
Copy link
Contributor

fntlnz commented Nov 12, 2019

@ldegio moving the falco-probe-loader script here makes it ineffective in all the cases where the script wants to build the module because the script doesn't have a way to find the driver folder.

sudo ./scripts/falco-probe-loader
* Unloading falco-probe, if present
* Running dkms install for falco
Error! Could not find module source directory.

@fntlnz
Copy link
Contributor

fntlnz commented Nov 13, 2019

I double checked that problem with the falco-probe-loader and it was a mistake on my side we are good to go for a merge here!

@poiana
Copy link
Contributor

poiana commented Nov 14, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, kris-nova, mfdii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fntlnz fntlnz merged commit 885e131 into dev Nov 14, 2019
@poiana poiana deleted the revert-1538-revert_name_change branch November 14, 2019 18:00
@fntlnz fntlnz added this to the 0.19.0 milestone Dec 2, 2019
@fntlnz fntlnz mentioned this pull request Feb 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fntlnz fntlnz fntlnz approved these changes

Assignees

@leodido leodido

@mfdii mfdii

@fntlnz fntlnz

@krisnova krisnova

Labels
approved dco-signoff: yes kind/cleanup lgtm release-note size/XXL
Projects
None yet
Milestone
0.19.0
Development

Successfully merging this pull request may close these issues.
6 participants
@leodido @krisnova @poiana @mfdii @fntlnz @ldegio